Skip to content

[App Check] Preliminary test of App Check 12 (Swift implementation) integration #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulb777 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[App Check] Preliminary test of App Check 12 (Swift implementation) integration #626

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27a2305
fix test
paulb777 Aug 21, 2026
aedfc76
Fix isPrepared logic in GIDAppCheck to check error instead of token
paulb777 Aug 21, 2026
239b0de
podspec testing
paulb777 Aug 21, 2026
82b7331
Address code review findings in GIDAppCheck
paulb777 Aug 22, 2026
3147ebb
appcheck 12 is now released
ncooke3 Sep 24, 2026
088b8f8
will revert: fix ci
ncooke3 Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review findings in GIDAppCheck
  • Loading branch information
@paulb777
paulb777 committed Sep 22, 2026
commit 82b73317266e33032d15651e368bcd1e25b4a121
12 changes: 3 additions & 9 deletions GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,6 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion)
[self.appCheck limitedUseTokenWithCompletion:^(GACAppCheckTokenResult * _Nonnull result) {
NSError * __block maybeError = result.error;
@synchronized (self) {
if (!result.token && !result.error) {
maybeError = [NSError errorWithDomain:kGIDAppCheckErrorDomain
code:kGIDAppCheckUnexpectedError
userInfo:nil];
}

if (!result.error) {
[self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey];
}
Expand All @@ -139,9 +133,9 @@ - (void)prepareForAppCheckWithCompletion:(nullable GIDAppCheckPrepareCompletion)
- (void)getLimitedUseTokenWithCompletion:(nullable GIDAppCheckTokenCompletion)completion {
dispatch_async(self.workerQueue, ^{
[self.appCheck limitedUseTokenWithCompletion:^(GACAppCheckTokenResult * _Nonnull result) {
if (!result.error) {
[self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey];
}
if (!result.error) {
[self.userDefaults setBool:YES forKey:kGIDAppCheckPreparedKey];
}
if (completion) {
completion(result.token, result.error);
}
Expand Down
Loading