Skip to content

[App Check] Preliminary test of App Check 12 (Swift implementation) integration #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulb777 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[App Check] Preliminary test of App Check 12 (Swift implementation) integration #626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27a2305
fix test
paulb777 Aug 21, 2026
aedfc76
Fix isPrepared logic in GIDAppCheck to check error instead of token
paulb777 Aug 21, 2026
239b0de
podspec testing
paulb777 Aug 21, 2026
82b7331
Address code review findings in GIDAppCheck
paulb777 Aug 22, 2026
3147ebb
appcheck 12 is now released
ncooke3 Sep 24, 2026
088b8f8
will revert: fix ci
ncooke3 Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
podspec testing
  • Loading branch information
@paulb777
paulb777 committed Sep 22, 2026
commit 239b0dedb8cef86eb5641d8bdefe30ed357b9858
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
# See #400 (https://github.com/google/GoogleSignIn-iOS/issues/400)
run: |
pod lib lint ${{ matrix.podspec }} --verbose \
${{ matrix.includePodspecFlag }} ${{ matrix.flag }}
${{ matrix.includePodspecFlag }} ${{ matrix.flag }} --sources=https://github.com/firebase/SpecsDev.git,https://github.com/firebase/SpecsStaging.git,https://cdn.cocoapods.org/
spm-build-test:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
2 changes: 1 addition & 1 deletion GoogleSignIn.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ The Google Sign-In SDK allows users to sign in with their Google account from th
]
s.ios.framework = 'UIKit'
s.osx.framework = 'AppKit'
s.dependency 'AppCheckCore', '~> 11.0'
s.dependency 'AppCheckCore', '~> 12.0'

@ncooke3 ncooke3 Sep 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging. Revert so CocoaPods is only compatible with AppCheckCore 11.x

Suggested change
s.dependency 'AppCheckCore', '~> 12.0'
s.dependency 'AppCheckCore', '~> 11.0'

s.dependency 'AppAuth', '~> 3.0'
s.dependency 'GTMAppAuth', '~> 6.0'
s.dependency 'GTMSessionFetcher/Core', '>= 3.3', '< 6.0'
Expand Down