Skip to content

Clarify expression hash input for CodeQL review #67057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Oct 9, 2026
Merged

Clarify expression hash input for CodeQL review #67057

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d22986
Initial plan
Copilot Oct 9, 2026
68f8c76
Document identifier-only expression hashing
Copilot Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Document identifier-only expression hashing 
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
  • Loading branch information
@pelikhan
Copilot and pelikhan authored Oct 9, 2026
commit 68f8c765dd437b3352c32e9be5c871a5a66ee6f1
1 change: 1 addition & 0 deletions pkg/workflow/expression_extraction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ func (e *ExpressionExtractor) generateEnvVarName(content string) string {

// Fall back to hash-based name for complex expressions
// Use SHA256 hash to generate a unique identifier
// content is unevaluated workflow expression source, not its runtime value; the digest is only an environment variable name.
hash := sha256.Sum256([]byte(content))
hashStr := hex.EncodeToString(hash[:])

Expand Down
Loading