Repository navigation
Clarify expression hash input for CodeQL review - #67057
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate go/weak-sensitive-data-hashing CodeQL alert
Clarify expression hash input for CodeQL review
Oct 9, 2026
pelikhan
marked this pull request as ready for review
October 9, 2026 01:12
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately reflects the surrounding implementation.
0 open findings
What changed in this PR
Clarifies that expression hashing generates deterministic environment variable names and does not process evaluated runtime data.
Changes:
- Documents the SHA-256 input and non-security purpose.
| File | Description |
|---|---|
pkg/workflow/expression_extraction.go |
Clarifies expression hashing behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CodeQL alert flagged hashing in expression extraction. The hash is derived from workflow expression source, not evaluated runtime data.