Warn instead of failing when Node is unavailable in the conclusion job by Copilot · Pull Request #65765 · github/gh-aw

Copilot · 2026-10-05T04:52:01Z

On runners without node on PATH, the conclusion job’s usage collector exits 127, leaving an error annotation and skipping the final file listing. Activity summary generation is best-effort and should not fail the collection step.

Collector: Guard both Node-based generators with a PATH check. Emit a GitHub Actions warning when Node is absent, then continue to the usage-file listing.
Regression coverage: Add shell cases for runners with and without Node.

Fixes conclusion job: collect_usage_artifact_files.sh calls bare node (exit 127) on runners without node on PATH #65105

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-10-05T05:04:57Z

@copilot review conclusion job and replace using node with actions/github-script

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-05T05:23:18Z

@copilot review conclusion job and replace using node with actions/github-script

Moved both generators into the conclusion job’s pinned actions/github-script step and removed their bare Node shell calls. Updated and recompiled the workflow output in commit 1588e63.

pelikhan

@copilot refactor in script file to minimize generated code

pelikhan · 2026-10-05T14:18:33Z

+        uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
+        with:
+          script: |
+            const path = require('path');


@copilot refactor in js file in sctions/setup/js

The usage generation logic now lives in actions/setup/js/generate_usage_artifacts.cjs; generated workflows delegate to it. Commit ac91ea7.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-05T14:42:12Z

@copilot refactor in script file to minimize generated code

Moved the conclusion orchestration into actions/setup/js/generate_usage_artifacts.cjs and reduced the generated script to a module call. Commit ac91ea7.

pelikhan · 2026-10-05T14:47:01Z

/smoke-copilot

github-actions · 2026-10-05T14:47:43Z

📰 BREAKING: Smoke Copilot is now investigating this issue comment. Sources say the story is developing...

Copilot

Copilot review overview

🟡 Changes recommended

The shell regression test is not run by CI, and the implementation contradicts the documented warning behavior.

Review effort: Balanced
Findings: 2

Open (2)

Regression test omitted from test-scripts target · New
Missing warning when Node is unavailable on PATH · New

What changed in this PR

Moves usage summary generation to actions/github-script, avoiding reliance on node being available on PATH.

Changes:

Separates file collection from best-effort JavaScript generation.
Exports generator entry points and adds a resilient orchestration wrapper.
Regenerates compiled workflow lockfiles.

File	Description
`actions/setup/sh/collect_usage_artifact_files.sh`	Removes direct Node invocations.
`actions/setup/sh/collect_usage_artifact_files_test.sh`	Adds collector regression coverage.
`actions/setup/js/generate_usage_activity_summary.cjs`	Exports `main`.
`actions/setup/js/generate_usage_activity_summary.test.cjs`	Tests the exported entry point.
`actions/setup/js/unified_session.cjs`	Exposes unified-session generation.
`actions/setup/js/generate_usage_artifacts.cjs`	Orchestrates best-effort generation and file listing.
`actions/setup/js/generate_usage_artifacts.test.cjs`	Tests failure handling and listing.
`pkg/workflow/notify_comment.go`	Adds the GitHub Script generation step.
`pkg/workflow/notify_comment_test.go`	Validates generated conclusion steps.
`.github/workflows/*.lock.yml`	Applies the generated step across compiled workflows.

Copilot · 2026-10-05T15:13:33Z

+output="$(RUNNER_TEMP="$TEST_DIR" PATH="$TEST_DIR/bin" /bin/bash "$SCRIPT" 2>&1)"
+! grep -q 'node not found on PATH' <<<"$output"
+grep -q '/tmp/gh-aw/usage/activity/collector-test-marker' <<<"$output"
+test ! -f /tmp/gh-aw/usage/activity/summary.json


Added this regression script to the test-scripts target in commit 80a1d1c; make test-scripts now exercises it.

Copilot · 2026-10-05T15:13:33Z

+		"      - name: Generate usage activity summary and unified session\n",
+		"        if: always()\n",
+		"        continue-on-error: true\n",
+		fmt.Sprintf("        uses: %s\n", pinAction("actions/github-script")),


The collector now emits a GitHub Actions warning when system node is absent, while generation stays on actions/github-script. The shell test covers both PATH cases; see commit 7532f42.

pelikhan · 2026-10-05T14:54:55Z

@copilot run pr-finisher skill

fix https://github.com/github/gh-aw/actions/runs/37326651081/job/111821643354

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-05T15:13:34Z

@copilot run pr-finisher skill

fix https://github.com/github/gh-aw/actions/runs/37326651081/job/111821643354

Ran the PR-finisher checks. I fixed the reproducible impacted Go test failure in 80a1d1c and restored the missing-Node warning plus both PATH regression cases in 7532f42. Local validation passes; CI is stale after these pushes and needs a maintainer re-trigger.

github-actions · 2026-10-05T23:07:33Z

🎉 This pull request is included in a new release.

Release: v0.91.0

Initial plan

1a23cea

Copilot AI assigned Copilot and pelikhan Oct 5, 2026

Copilot AI linked an issue Oct 5, 2026 that may be closed by this pull request

conclusion job: collect_usage_artifact_files.sh calls bare node (exit 127) on runners without node on PATH #65105

Closed

Copilot started work on behalf of pelikhan October 5, 2026 04:52 View session

Warn and continue usage collection when Node is unavailable

424ced9

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix bare node call in conclusion job for runners without node on PATH~~ Warn instead of failing when Node is unavailable in the conclusion job Oct 5, 2026

Copilot finished work on behalf of pelikhan October 5, 2026 04:59

Copilot AI requested a review from pelikhan October 5, 2026 04:59

Copilot started work on behalf of pelikhan October 5, 2026 05:05 View session

Run conclusion usage generators via github-script

1588e63

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 5, 2026 05:23

This was referenced Oct 5, 2026

[pr-review] Daily PR Code Quality Review — 37270027902 #65790

Closed

[PR Triage Report] PR triage report — 2026-10-05 #65799

Closed

[PR Triage Report] PR triage report - 2026-10-05 #65854

Closed

pelikhan reviewed Oct 5, 2026

View reviewed changes

Copilot started work on behalf of pelikhan October 5, 2026 14:19 View session

pelikhan marked this pull request as ready for review October 5, 2026 14:30

Copilot AI balanced review requested due to automatic review settings October 5, 2026 14:30

Copilot AI and others added 2 commits October 5, 2026 14:33

Move conclusion usage generation into JS module

8930081

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Handle usage listing I/O errors explicitly

ac91ea7

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot started reviewing on behalf of pelikhan October 5, 2026 14:42 View session

Copilot finished work on behalf of pelikhan October 5, 2026 14:42

Copilot AI requested a review from pelikhan October 5, 2026 14:42

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Copilot started work on behalf of pelikhan October 5, 2026 14:55 View session

Copilot AI and others added 2 commits October 5, 2026 15:09

Register usage collector test and fix stale schema assertion

80a1d1c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Warn when system Node is missing during usage collection

7532f42

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 5, 2026 15:15

pelikhan merged commit 73109ca into main Oct 5, 2026
2 checks passed

pelikhan deleted the copilot/fix-node-bare-call branch October 5, 2026 15:32

Conversation

Copilot AI commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

Copilot AI commented Oct 5, 2026

Uh oh!

pelikhan left a comment

Choose a reason for hiding this comment

Uh oh!

pelikhan Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 5, 2026

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

Copilot AI commented Oct 5, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading