Skip to content

[pr-review] Daily PR Code Quality Review β€” 37270027902Β #65790

Description

@github-actions

Summary

PR Author Issues Signal
#65768 drain3 weights github-actions[bot] 0 🟒
#65767 Short OTLP attribute masking Copilot 0 🟒
#65766 Exact-path protected-file exclusions Copilot 2 🟑
#65765 Warn when Node unavailable in conclusion job Copilot 0 (partial review) 🟒
#65761 Stop retries on tool-call ID schema errors Copilot 1 🟒

Overall quality signal: 🟒 (about 0.6 issues/PR; 5 PRs reviewed)

Full Findings

#65768 β€” chore: update drain3 default log pattern weights

  • No issues. The change only touches the generated JSON data file.
  • Minor: the file now ends without a trailing newline and the formatting churn adds noise.

#65767 β€” Avoid masking short OTLP attribute values

  • No Go changes. Shell and docs are updated together.
  • The new test case has want and wantNot assertions covering the 1, 3 and 4 character boundary.
  • emit_mask has a clear purpose, and the minimum length is a named constant.
  • No issues.

#65766 β€” Support exact-path protected-file exclusions

  • splitProtectedFilesExcludes is unexported, so no doc comment is required. A short comment would help explain the leading / convention.
  • The same split-and-apply block is duplicated in safe_outputs_config_generation.go and safe_outputs_config_runtime.go. Consider extracting a shared helper.
  • Tests use require.NoError and have assertions.
  • No oversized functions in the diff.

#65765 β€” Warn instead of failing when Node is unavailable in the conclusion job

  • The diff has more than 300 files, mostly regenerated .lock.yml files, so the full diff was unavailable. Only the first 5 files were sampled.
  • The sampled lock-file changes wrap the generators in try/catch and report with core.warning, so error handling is present.
  • No issues in the sampled files.

#65761 β€” Stop Copilot retries on tool-call ID schema errors

  • The new exported isToolCallIdSchemaError has no JSDoc, unlike neighbouring helpers.
  • Tests assert on the matcher, the classifier and the retry behaviour.
  • No oversized functions were introduced.

Generated by πŸ–±οΈ Daily PR Code Quality Review Β· copilot Β· auto Β· 26.8 AIC Β· βŒ– 5.36 AIC Β· ⊞ 7.5K Β· β—·

  • expires on Oct 5, 2026, 10:01 PM UTC-08:00

Activity

  1. github-actions commented on Oct 6, 2026

    @github-actions
    ContributorAuthor

    This issue is being closed as outdated. A newer issue has been created: #66038

    View newer issue


    This action was performed automatically by the Daily PR Code Quality Review workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions