Skip to content

Remove dead close_discussion instructions from daily reports #65571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Oct 4, 2026
Merged

Remove dead close_discussion instructions from daily reports #65571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b52560
Initial plan
Copilot Oct 4, 2026
576f860
Remove stale manual discussion closing from daily reports
Copilot Oct 4, 2026
41d512d
Apply remaining changes
Copilot Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 3 additions & 35 deletions .github/workflows/agentic_commands.yml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions .github/workflows/daily-issues-report.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 3 additions & 11 deletions .github/workflows/daily-issues-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,20 +265,12 @@ Use the `upload asset` tool to upload both charts:
2. Upload `/tmp/gh-aw/python/charts/issue_clusters.png`
3. Collect the returned URLs for embedding in the discussion

## Phase 5: Close Previous Discussions

Before creating the new discussion, find and close previous daily issues discussions:

1. Search for discussions with title prefix "[daily issues]"
2. Close each found discussion with reason "OUTDATED"
3. Add a closing comment: "This discussion has been superseded by a newer daily issues report."

Use the `close_discussion` safe output for each discussion found.

## Phase 6: Create Discussion Report
## Phase 5: Create Discussion Report

Create a new discussion with the comprehensive report.

Older daily issues discussions are closed automatically by `close-older-discussions: true` via `shared/daily-audit-discussion.md`.

**Formatting Guideline**: Use h3 (###) or lower for all headers in your report to maintain proper document hierarchy. The discussion title serves as h1, so all content headers should start at h3.

**Report Structure Guidelines**
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/daily-secrets-analysis.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/daily-secrets-analysis.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Generate a daily report analyzing secret usage in all `.lock.yml` files in the r
3. Track changes in secret usage patterns
4. Identify security issues or anomalies
5. Post results as a discussion
6. Close older daily secrets discussions
6. Let the configured safe output automatically close older daily secrets discussions

## Current Context

Expand Down Expand Up @@ -300,7 +300,7 @@ For detailed information about secret usage patterns, see:
- Be posted in "audits" category
- Expire after 3 days
- Replace any existing daily secrets discussion (max: 1)
3. **Close older discussions** older than 3 days using `close_discussion` safe output
3. Older daily secrets discussions are closed automatically by `close-older-discussions: true` via `shared/daily-audit-discussion.md`; no manual closing is needed.

## Success Criteria

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ require (

require (
github.com/rhysd/actionlint v1.7.12
go.yaml.in/yaml/v3 v3.0.5
golang.org/x/net v0.59.0
)

Expand Down Expand Up @@ -112,7 +113,6 @@ require (
go.opentelemetry.io/otel/metric v1.45.0 // indirect
go.opentelemetry.io/otel/trace v1.45.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
go.yaml.in/yaml/v3 v3.0.5 // indirect
go.yaml.in/yaml/v4 v4.0.0-rc.6 // indirect
golang.org/x/exp v0.0.0-20240909161429-701f63a606c0 // indirect
golang.org/x/oauth2 v0.36.0 // indirect
Expand Down
11 changes: 2 additions & 9 deletions pkg/workflow/schemas/github-workflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,8 @@
"queue": {
"$comment": "https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-queueing-multiple-pending-runs",
"description": "Controls how pending jobs or workflow runs are queued within a concurrency group. With the default `single`, at most one run can be pending — additional pending runs cancel the previous one. With `max`, up to 100 runs can be pending and are processed in FIFO order. The combination of `queue: max` and `cancel-in-progress: true` is not allowed.",
"oneOf": [
{
"type": "string",
"enum": ["single", "max"]
},
{
"$ref": "#/definitions/expressionSyntax"
}
],
"type": "string",
"enum": ["single", "max"],
Comment on lines +45 to +46
"default": "single"
}
},
Expand Down
Loading