Skip to content

Remove dead close_discussion instructions from daily reports - #65571

Merged
pelikhan merged 3 commits into
mainfrom
copilot/deep-report-remove-dead-instructions
Oct 4, 2026
Merged

pelikhan merged 3 commits into
mainfrom
copilot/deep-report-remove-dead-instructions

Conversation

Copilot AI commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Both daily reports requested an unavailable close_discussion tool, despite inheriting automatic cleanup through create-discussion with close-older-discussions: true.

  • Prompt cleanup: Remove the manual closing phase from Daily Issues Report and stale closing instructions from Daily Secrets Analysis. Clarify automatic cleanup and renumber report creation.
  • Generated metadata: Refresh both workflow lock files; safe-output configuration remains unchanged.

Copilot AI and others added 2 commits October 4, 2026 13:30
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove dead close_discussion instructions from reports Remove dead close_discussion instructions from daily reports Oct 4, 2026
Copilot AI requested a review from pelikhan October 4, 2026 13:35
@pelikhan
pelikhan marked this pull request as ready for review October 4, 2026 13:37
Copilot AI balanced review requested due to automatic review settings October 4, 2026 13:37
@pelikhan
pelikhan merged commit 8d7ff42 into main Oct 4, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/deep-report-remove-dead-instructions branch October 4, 2026 13:37
Copilot stopped reviewing on behalf of pelikhan due to an error October 4, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Copilot review overview

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Updates GitHub Actions workflow-related schemas/configs and associated documentation, including dependency adjustments for YAML parsing.

Changes:

  • Tightens concurrency.queue schema validation to only allow the literal values single and max.
  • Promotes go.yaml.in/yaml/v3 from indirect to direct dependency in go.mod.
  • Updates daily audit workflow docs/locks and trims the agentic slash-command routing configuration.
File Description
pkg/​workflow/​schemas/​github-workflow.json Restricts concurrency.queue schema to fixed string enum
go.mod Makes YAML v3 module a direct dependency
.github/​workflows/​daily-secrets-analysis.md Documentation update: clarify older discussions auto-close behavior
.github/​workflows/​daily-secrets-analysis.lock.yml Regenerated lock metadata hash
.github/​workflows/​daily-issues-report.md Removes manual “close previous discussions” phase; notes auto-close
.github/​workflows/​daily-issues-report.lock.yml Regenerated lock metadata + harness version
.github/​workflows/​agentic_commands.yml Updates generated command/workflow lists and routing payloads

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +45 to +46
"type": "string",
"enum": ["single", "max"],
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.91.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] Remove dead close_discussion instructions from daily-issues-report and daily-secrets-analysis

3 participants