Skip to content

ref(redis)!: Drop send_default_pii support #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 2 commits into from
Oct 5, 2026
Merged

ref(redis)!: Drop send_default_pii support #7824

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ba446
ref(redis)!: Drop `send_default_pii` support
ericapisani Oct 1, 2026
c67f014
update assertion
ericapisani Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update assertion
  • Loading branch information
@ericapisani
ericapisani committed Oct 1, 2026
commit c67f0144d053be04e6be3300c93b448a07a2e8df
5 changes: 4 additions & 1 deletion tests/integrations/redis/test_redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def test_basic(sentry_init, capture_events):
"type": "redis",
}


@pytest.mark.parametrize(
"data_collection, expected_first_ten",
[
Expand Down Expand Up @@ -87,6 +88,7 @@ def test_redis_pipeline_data_collection(
assert pipeline_span["name"] == "redis.pipeline.execute"
assert pipeline_span["attributes"]["sentry.op"] == "db.redis"


def test_pii_data_redacted(
sentry_init,
capture_events,
Expand Down Expand Up @@ -125,7 +127,7 @@ def test_pii_data_redacted(
@pytest.mark.parametrize(
"data_collection, expected_description",
[
({"database_query_data": False}, "SET 'somekey1'"),
({"database_query_data": False}, "SET 'somekey1' [Filtered]"),
({"database_query_data": True}, "SET 'somekey1' 'my secret string1'"),
({}, "SET 'somekey1' 'my secret string1'"),
],
Expand Down Expand Up @@ -165,6 +167,7 @@ def test_data_collection_database_query_data(
assert set_span["attributes"][SPANDATA.DB_QUERY_TEXT] == expected_description
assert set_span["attributes"]["sentry.op"] == "db.redis"


def test_no_data_truncation_by_default(sentry_init, capture_items):
sentry_init(
integrations=[RedisIntegration()],
Expand Down
Loading