ref(redis)!: Drop send_default_pii support - #7824
Open
ericapisani wants to merge 2 commits into
Open
ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
Redis command arguments are now gated solely on `data_collection["database_query_data"]`. The `send_default_pii` fallback in `_get_safe_command` is removed. Tests that exercised `send_default_pii` (including the precedence test) are removed, and the remaining ones use `data_collection` instead. Fixes PY-2837 Fixes #7608
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 27ba446. Configure here.
Contributor
Codecov Results 📊✅ 58106 passed | ⏭️ 2727 skipped | Total: 60833 | Pass Rate: 95.52% | Execution Time: 163m 21s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2055 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.35% 90.15% -0.2%
==========================================
Files 202 185 -17
Lines 26551 20855 -5696
Branches 9856 7240 -2616
==========================================
+ Hits 23988 18800 -5188
- Misses 2563 2055 -508
- Partials 1487 1205 -282Generated by Codecov Action |
pabloDeputter
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis command arguments are now gated solely on
data_collection["database_query_data"]. Thesend_default_piifallback in_get_safe_commandis removed.Tests that exercised
send_default_pii(including the precedence test) are removed, and the remaining ones usedata_collectioninstead.Fixes PY-2837
Fixes #7608