Skip to content

Faster "hot" restore #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 2 commits into from
Feb 28, 2018
Merged

Faster "hot" restore #3092

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99c6603
Lazily initialize framework maps
vbfox Feb 27, 2018
a2e0c41
Split Utils for the net from the rest
vbfox Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Lazily initialize framework maps 
They are not needed on a simple restore but take time
  • Loading branch information
@vbfox
vbfox committed Feb 27, 2018
commit 99c66030e8396d519bbcd350b91e7df39d9a81e9
18 changes: 13 additions & 5 deletions src/Paket.Core/Versioning/FrameworkHandling.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,22 +1321,30 @@ module SupportCalculation =
|> List.map (fun p -> p, getSupportedPortables p)
|> ofSeq

let mutable private supportMap = optimizeSupportMap (createInitialSupportMap())
let mutable private supportMap: SupportMap option = None

let private getSupportMap () =
match supportMap with
| Some supportMap ->
supportMap
| None ->
supportMap <- Some (optimizeSupportMap (createInitialSupportMap()))
supportMap.Value

let getSupportedPreCalculated (p:PortableProfileType) =
match supportMap.TryGetValue p with
match getSupportMap().TryGetValue p with
| true, v -> v
| _ ->
match p with
| UnsupportedProfile tfs ->
match supportMap.TryGetValue p with
match getSupportMap().TryGetValue p with
| true, v -> v
| _ ->
let clone = supportMap |> toSeq |> ofSeq
let clone = getSupportMap() |> toSeq |> ofSeq
clone.[p] <- getSupportedPortables p
let opt = optimizeSupportMap clone
let result = opt.[p]
supportMap <- opt
supportMap <- Some opt
result
| _ -> failwithf "Expected that default profiles are already created."

Expand Down