Repository navigation
Faster "hot" restore - #3092
Merged
Merged
Faster "hot" restore#3092
Conversation
They are not needed on a simple restore but take time
This ensure that ServicePointManager.SecurityProtocol isn't set in cases where the network doesn't need to be touched (It's pretty slow)
matthid
approved these changes
Feb 27, 2018
matthid
left a comment
matthid
left a comment
Member
There was a problem hiding this comment.
Utils.fs was kind of long anyway.
Member
|
mhm it broke one integration test. weird
2018-02-27 21:42 GMT+01:00 Matthias Dittrich <notifications@github.com>:
… ***@***.**** approved this pull request.
Utils.fs was kind of long anyway.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3092 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNHiMeQBQJ12kT1SBua1-WREnKwIBks5tZGiygaJpZM4SVgpt>
.
|
Member
|
ok test failure is unrelated. it's red on #3090 as well |
Member
|
ok seems https://www.nuget.org/packages/Microsoft.Diagnostics.Tracing.EventSource.Redist/ released a package 7h ago. I will fix the test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two slow part from doing
paket restorewhen a restore isn't neededServicePointManager.SecurityProtocolis costly as it initialize a lot of .Net subsystems we don't otherwise use so I split theUtilsmodule in two. As the network isn't used if everything is there the static constructor ofNetUtilsis never called.supportMapwith it's initial value lazy. It's costly and not used in such restores.