Skip to content

Finalize targets - #2684

Merged
matthid merged 5 commits into
masterfrom
finalize_targets
Aug 28, 2017
Merged

matthid merged 5 commits into
masterfrom
finalize_targets

Conversation

@matthid

@matthid matthid commented Aug 28, 2017

Copy link
Copy Markdown
Member
  • Bundle the correct targets file
  • Be compatible with the old targets file
  • *.references are now called *.paket.resolved in the obj directory

- Bundle the correct targets file
- Be compatible with the old targets file
- *.references are now called *.paket.resolved in the obj directory
@matthid

matthid commented Aug 28, 2017

Copy link
Copy Markdown
Member Author

@alfonsogarciacaro I renamed the files to *.paket.resolved instead of *.paket.references as that probably better matches their content. Because of all the issues with the alpha I'll do another beta before releasing this. Thanks for the testing!

@alfonsogarciacaro

Copy link
Copy Markdown

@matthid Ok, thanks! But please don't change the name again after Fable 1.2 RTM is out ;)

@matthid

matthid commented Aug 28, 2017

Copy link
Copy Markdown
Member Author

@alfonsogarciacaro Sure :) We don't try to break stuff we released but we didn't release the other name-change yet ;)

@matthid

matthid commented Aug 28, 2017

Copy link
Copy Markdown
Member Author

Tbh I didn't even expected fable to pick that up soooo fast 👍 But in the end it turned out to be good because we found some bugs before releasing them to the wild :)

let tmpPaketFolder = (scenarioTempPath scenario) @@ "../.paket"
let tmpPaketFolder = (scenarioTempPath scenario) @@ ".paket"
let targetsFile = FullName(__SOURCE_DIRECTORY__ + "../../../src/Paket/embedded/Paket.Restore.targets")
let paketExe = FullName(__SOURCE_DIRECTORY__ + "../../../.paket/paket.exe")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now magic mode and magic mode downloaded the latest stable instead of testing the current build :/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it basically tested the current targets file with an older release. @forki Do we really need to maintain that kind of compat as well?

@matthid
matthid merged commit c3a8cc5 into master Aug 28, 2017
matthid added a commit to matthid/Paket that referenced this pull request Jul 1, 2019
@matthid matthid mentioned this pull request Jul 1, 2019
2 tasks done
@matthid
matthid deleted the finalize_targets branch July 2, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants