Skip to content

Paket: 5.92.0-alpha001 fail to generate correct project.assets.json #2680

Closed
Closed
Paket: 5.92.0-alpha001 fail to generate correct project.assets.json#2680

Description

@MangelMaxime
MangelMaxime
opened on Aug 28, 2017

I just updating one of my project to use NETStandard 2.0.

When using paket 5.92.0-alpha001 I got this project.assets.json which is wrong. It does not contains my dependencies.

If I use paket 5.91.0, then I got this file.

As you can see the first file is missing a lot of deps like Fable.Core.

Here is my paket.dependencies:

framework: netstandard2.0

source https://www.nuget.org/api/v2

nuget Fable.Core prerelease
nuget Fable.Elmish.React
nuget Fable.Elmish.Browser
nuget Fable.Elmish.Debugger
nuget Fable.PowerPack
nuget Fable.React prerelease

clitool dotnet-fable prerelease

group Build
framework: net46

    source https://nuget.org/api/v2
    nuget FSharp.Core  redirects:force, content:none
    nuget FAKE

    github fsharp/FAKE modules/Octokit/Octokit.fsx

Paket.references:

Fable.Core
Fable.React

Please tell me if you need more infos.

Activity

  1. matthid commented on Aug 28, 2017

    @matthid
    matthid
    on Aug 28, 2017
    Member

    Yes

    • what is your project layout, ie relative paths of project file, paket.references file, paket.exe, Paket.Restore.Targets and lockfile. Please make sure everything is correct regarding to casing if you are not on windows
    • what are the generated *.references files in the obj/ directory.
    • dependencies-/lock- file
    • Are there warnings errors emitted by paket in your build process?

  2. MangelMaxime commented on Aug 28, 2017

    @MangelMaxime
    MangelMaxime
    on Aug 28, 2017
    Author

    Hello @matthid you can find the project here.

    To summarize I go the following layout:

    /.paket/paket.exe
/paket.lock
/paket.dependencies
/src/Fulma/paket.reference
/src/Fulma/Fulma.fsproj

    Here is my Fulma.fsproj.netstandard2.0.references file.

    And here is my full obj folder: obj.zip

    There is no warning output during my build process by paket. output.txt

  3. matthid commented on Aug 28, 2017

    @matthid
    matthid
    on Aug 28, 2017
    Member

    Ah good, will try to reproduce later

  4. matthid commented on Aug 28, 2017

    @matthid
    matthid
    on Aug 28, 2017
    Member

    Ok can you tell me for idiots what I need to do :)

    Assume I don't have any idea of fable and just cloned your repository, how do I reproduce the bug?

  5. matthid commented on Aug 28, 2017

    @matthid
    matthid
    on Aug 28, 2017
    Member

    Problem is all your files look correct, but from your error description it looks like they are never actually read in the build process. Something is wrong there.

  6. matthid commented on Aug 28, 2017

    @matthid
    matthid
    on Aug 28, 2017
    Member

    OK I noticed something: Your Paket.Restore.targets is not the latest one and paket install didn't update it either. Now I have two questions:

    • @forki what else do I need to do apparently something else is required to embed/update the targets file?
    • Apparently I broke compat with older Targets files, thanks for the report, because I expected this to work...

  7. matthid commented on Aug 28, 2017

    @matthid
    matthid
    on Aug 28, 2017
    Member

    Ah OK its because I removed the old file when only netstandard20 is there (We discussed that it is safe to assume it only is required for fable compat when using netstandard16). Maybe we need to revisit that for at least a couple of versions... (until we can assume people have updated their targets files?)

    /cc @forki because of compat concerns

  8. forki commented on Aug 28, 2017

    @forki
    forki
    on Aug 28, 2017 via email
    Member

  9. matthid commented on Aug 28, 2017

    @matthid
    matthid
    on Aug 28, 2017
    Member

    Will be fixed with #2684, thanks for reporting and testing the alpha!

  10. matthid
    closed this as completedon Aug 28, 2017

  11. MangelMaxime commented on Aug 28, 2017

    @MangelMaxime
    MangelMaxime
    on Aug 28, 2017
    Author

    Thanks for the quick fix :)

  12. MangelMaxime commented on Aug 29, 2017

    @MangelMaxime
    MangelMaxime
    on Aug 29, 2017
    Author

    I tested with 5.92.0-beta001 and it's working. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions