Skip to content

Package names are compared using non-linguistic Ordinal comparison #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 1 commit into from
Dec 4, 2016
Merged

Package names are compared using non-linguistic Ordinal comparison #2067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Paket.Core/Domain.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module Paket.Domain

open System
open System.IO
open System.Text.RegularExpressions

Expand Down Expand Up @@ -27,7 +28,7 @@ type PackageName =
interface System.IComparable with
member this.CompareTo that =
match that with
| :? PackageName as that -> this.GetCompareString().CompareTo(that.GetCompareString())
| :? PackageName as that -> StringComparer.Ordinal.Compare(this.GetCompareString(), that.GetCompareString())
| _ -> invalidArg "that" "cannot compare value of different types"

/// Function to convert a string into a NuGet package name
Expand Down Expand Up @@ -82,7 +83,7 @@ type GroupName =
interface System.IComparable with
member this.CompareTo that =
match that with
| :? GroupName as that -> this.GetCompareString().CompareTo(that.GetCompareString())
| :? GroupName as that -> StringComparer.Ordinal.Compare(this.GetCompareString(), that.GetCompareString())
| _ -> invalidArg "that" "cannot compare value of different types"

/// Function to convert a string into a group name
Expand Down