Skip to content

Package names are compared using non-linguistic Ordinal comparison - #2067

Merged
forki merged 1 commit into
fsprojects:masterfrom
tomasdeml:package-name-comparison-bug
Dec 4, 2016
Merged

forki merged 1 commit into
fsprojects:masterfrom
tomasdeml:package-name-comparison-bug

Conversation

@tomasdeml

Copy link
Copy Markdown
Contributor

Test ParserSpecs.should parse lock file with depdencies fails under OS with Czech regional settings because of linguistic comparison of Chessie package name. In Czech, ch is a diagraph that is inserted between H and I letters in collation order. I fixed the issue by using non-linguistic ordinal comparison.

@forki

forki commented Dec 4, 2016

Copy link
Copy Markdown
Member

cool. thanks a lot!

@forki
forki merged commit 44c91c5 into fsprojects:master Dec 4, 2016
@tomasdeml
tomasdeml deleted the package-name-comparison-bug branch December 4, 2016 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants