Skip to content

Fix unsupported https scheme in web proxy #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 1 commit into from
Sep 22, 2015
Merged

Fix unsupported https scheme in web proxy #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix unsupported https scheme in web proxy
  • Loading branch information
@dedale
dedale committed Sep 22, 2015
commit 533886c0a52a2bd72e9834b0c391fd2981f11ece
2 changes: 1 addition & 1 deletion src/Paket.Bootstrapper/EnvProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ private void AddProxy(string scheme, string[] bypassList)
Uri envUri;
if (Uri.TryCreate(envVarValue, UriKind.Absolute, out envUri))
{
var proxy = new WebProxy(new Uri(string.Format("{0}://{1}:{2}", scheme, envUri.Host, envUri.Port)));
var proxy = new WebProxy(new Uri(string.Format("http://{0}:{1}", envUri.Host, envUri.Port)));
NetworkCredential credentials;
if (TryGetCredentials(envUri, out credentials))
proxy.Credentials = credentials;
Expand Down
2 changes: 1 addition & 1 deletion src/Paket.Core/Utils.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ let envProxies () =
else
match Uri.TryCreate(envVarValue, UriKind.Absolute) with
| true, envUri ->
let proxy = new WebProxy(new Uri(sprintf "%s://%s:%d" scheme envUri.Host envUri.Port))
let proxy = new WebProxy(new Uri(sprintf "http://%s:%d" envUri.Host envUri.Port))
proxy.Credentials <- Option.toObj <| getCredentials envUri
proxy.BypassProxyOnLocal <- true
proxy.BypassList <- bypassList
Expand Down