Skip to content

Fix unsupported https scheme in web proxy - #1080

Merged
forki merged 1 commit into
fsprojects:masterfrom
dedale:master
Sep 22, 2015
Merged

forki merged 1 commit into
fsprojects:masterfrom
dedale:master

Conversation

@dedale

@dedale dedale commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

Finally found a way to push the fix.
Hope it solves #1079

@forki
forki merged commit 533886c into fsprojects:master Sep 22, 2015
@forki

forki commented Sep 22, 2015

Copy link
Copy Markdown
Member

cool thanks.
I fixed the red test cases. could you please review f796058? thx

@dedale

dedale commented Sep 22, 2015

Copy link
Copy Markdown
Contributor Author

Sorry for the unit tests. You just need to fix the scheme, not the port.
Updated my PR BTW.

@dedale

dedale commented Sep 22, 2015

Copy link
Copy Markdown
Contributor Author

Mmm If i look at AppVeyor logs, it seems it automatically replaces http://proxy.local:443/ with https://proxy.local/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants