Repository navigation
paket.template - file type doesn't respect dir without slash at the end #698
Description
type file
id xxx
version 1.0
authors xxx
description
description of this test package
files
bin/Debug/ ==> lib
bin/Debug doesn't work
bin/Debug/ works
/cc @mavnn
Activity
forki commentedon Mar 12, 2015
ok this one is my fault. I changed that to FAKE's globbing. and the behaviour is already in FAKE.
Could you try to find a workaround around https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/TemplateFile.fs#L328?
we might even discuss changes to the globbing in FAKE
// @colinbull
workaround - closes fsprojects#698
Merge pull request #699 from theimowski/master
forki commentedon Mar 12, 2015
I wonder if it really copies the whole directory including subdirectories.
theimowski commentedon Mar 12, 2015
In my case it did
forki commentedon Mar 12, 2015
Ok then I think it should go upstream into FAKE
forki commentedon Mar 12, 2015
It already annoyed some people there
theimowski commentedon Mar 12, 2015
Go for It
colinbull commentedon Mar 12, 2015
There is a slight subtly here, when we have the trailing slash this allows the globbing implementation to figure out that it is a directory so something like
bin\Debug\will be turned into the following search tokens,[Directory(bin); Directory(Debug)]. Now if we don't have a the trailing slash we get[Directory(bin); Filename(Debug)], this is supports extension-less files. Now considering how rare they I could just test to see if the last token has an extension and emit the correct token. What do you think?forki commentedon Mar 12, 2015
Please take a look at 07a0b07
and fsprojects/FAKE@8f83457 - I thought the
if Directory.Existswould handle this?colinbull commentedon Mar 12, 2015
This causes a fair few test failures. I have added some failing tests and a fix colinbull/FAKE@e3eb041 sent you a PR.
forki commentedon Mar 12, 2015
yep. just reverted that thing. It's not correct. And the workarounf Paket will also fail on wildcards ;-(
Revert "workaround - closes #698"
theimowski commentedon Mar 12, 2015
Should we revert then?
forki commentedon Mar 12, 2015
could you please try with 0.33.15 - it uses colin's stuff from FAKE
theimowski commentedon Mar 12, 2015
works fine, thanks
colinbull commentedon Mar 12, 2015
Good too hear 👍
forki commentedon Mar 12, 2015
with 57a4455#diff-5850744305c961bd47fb58bd09062c26R329 applied it seems to work even for complicated stuff like: fsprojects/FsReveal@18fcad5#diff-38a9089c5d441003f1b29b8880065f07R15