Repository navigation
paket.template - file type doesn't respect dir without slash at the end #698
Description
Activity
ok this one is my fault. I changed that to FAKE's globbing. and the behaviour is already in FAKE.
Could you try to find a workaround around https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/TemplateFile.fs#L328?
we might even discuss changes to the globbing in FAKE
// @colinbull- added a commit that references this issue
on Mar 12, 2015 - added a commit that references this issue
on Mar 12, 2015 I wonder if it really copies the whole directory including subdirectories.
In my case it did
Ok then I think it should go upstream into FAKE
It already annoyed some people there
Go for It
There is a slight subtly here, when we have the trailing slash this allows the globbing implementation to figure out that it is a directory so something like
bin\Debug\will be turned into the following search tokens,[Directory(bin); Directory(Debug)]. Now if we don't have a the trailing slash we get[Directory(bin); Filename(Debug)], this is supports extension-less files. Now considering how rare they I could just test to see if the last token has an extension and emit the correct token. What do you think?Please take a look at 07a0b07
and fsprojects/FAKE@8f83457 - I thought theif Directory.Existswould handle this?This causes a fair few test failures. I have added some failing tests and a fix colinbull/FAKE@e3eb041 sent you a PR.
yep. just reverted that thing. It's not correct. And the workarounf Paket will also fail on wildcards ;-(
- added a commit that references this issue
on Mar 12, 2015 Should we revert then?
could you please try with 0.33.15 - it uses colin's stuff from FAKE
works fine, thanks
Good too hear 👍
with 57a4455#diff-5850744305c961bd47fb58bd09062c26R329 applied it seems to work even for complicated stuff like: fsprojects/FsReveal@18fcad5#diff-38a9089c5d441003f1b29b8880065f07R15
bin/Debugdoesn't workbin/Debug/works/cc @mavnn