feat: Add consistency_level to the Milvus online store config - #6921
Open
simonhearne wants to merge 2 commits into
Open
simonhearne wants to merge 2 commits into
simonhearne wants to merge 2 commits into
Conversation
Adds two optional settings, each Strong, Bounded, Session or Eventually: consistency_level is sent with every read and search, and collection_consistency_level is set when Feast creates a collection. When unset nothing is sent, so Milvus keeps its default (Bounded) exactly as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6921 +/- ##
=======================================
Coverage 48.62% 48.63%
=======================================
Files 427 427
Lines 53845 53855 +10
Branches 7844 7846 +2
=======================================
+ Hits 26181 26191 +10
Misses 25797 25797
Partials 1867 1867
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds two optional Milvus online store settings, each
Strong,Bounded,SessionorEventually:consistency_levelis sent with every read and search (query,search, keywordquery).collection_consistency_levelis set when Feast creates a collection. It becomes the collection'sdefault for requests that don't specify a level, e.g. from other clients.
The two are independent. When they are unset nothing is sent, so Milvus keeps its default
(
Bounded), which is the current behaviour.With
Bounded, a read issued straight after materialization may briefly miss the newest writes.consistency_level: Strongmakes Feast's reads always see the latest writes, at the cost of higherread latency, and takes effect without recreating collections.
Which issue(s) this PR fixes:
N/A
Checks
git commit -s)Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit (mocked client): neither level sent when unset;
consistency_levelsent only to query,search and keyword query;
collection_consistency_levelsent only tocreate_collection;different values for each are applied independently; invalid values rejected.
Server: collection level is
Boundedby default and followscollection_consistency_level;with
consistency_level: Strongon aBoundedcollection, a write is visible to the next read.Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in
sdk/python/tests/integration/online_store/test_milvus_remote.pyare markedintegrationand skip unlessZILLIZ_URIandZILLIZ_TOKENare set; they passed against a local Milvus 2.6.0, a local Milvus 3.0.2 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.Misc
Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882, #6895 and #6917.