feat: Support token, uri and db_name in the Milvus online store - #6895
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6895 +/- ##
==========================================
+ Coverage 48.06% 48.07% +0.01%
==========================================
Files 427 427
Lines 53591 53605 +14
Branches 7799 7802 +3
==========================================
+ Hits 25758 25772 +14
Misses 25980 25980
Partials 1853 1853
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
approved these changes
Oct 1, 2026
The Milvus client was always built from host:port with a username:password token, so Zilliz Cloud API keys could not be used and every collection landed in the default database. Adds three optional config fields: - token: an API key or username:password; takes precedence over username/password. - uri: a full endpoint; takes precedence over host/port (and over a Milvus Lite path). - db_name: the Milvus database to use. Existing configurations build exactly the same client arguments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
ntkathole
force-pushed
the
feat/milvus-token-uri-db
branch
from
October 1, 2026 04:12
8c75f09 to
6478647
Compare
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Milvus client was always built as
MilvusClient(uri=f"{host}:{port}", token=f"{username}:{password}").API keys couldn't be used, and there was no way to choose a database.
This PR adds three new optional config parameters:
urihost/port, and over a Milvus Litepath.tokenusername:password. Takes precedence overusername/password.db_nameExisting configs build exactly the same client arguments (covered by a test). The docs add a Zilliz
Cloud example that reads the token from an environment variable.
Which issue(s) this PR fixes:
N/A
Checks
git commit -s)Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit: parametrized client arguments for existing configs, token/uri precedence and
db_name;uribeatspath;pathstill selects Milvus Lite.Server: collections are created in
db_nameand not indefault. Token authentication wasexercised against Zilliz Cloud with an API key.
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in
sdk/python/tests/integration/online_store/test_milvus_remote.pyare markedintegrationand skip unlessZILLIZ_URIandZILLIZ_TOKENare set; they passed against a local Milvus 2.6.0 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.