Skip to content

fix: Only update stable branch when a release was actually created #6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pujitha24 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Only update stable branch when a release was actually created #6910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ jobs:
name: release
runs-on: ubuntu-latest
needs: validate_version_bumps
outputs:
released: ${{ steps.release.outputs.released }}
env:
GITHUB_TOKEN: ${{ github.event.inputs.token }}
GIT_AUTHOR_NAME: feast-ci-bot
Expand Down Expand Up @@ -173,14 +175,22 @@ jobs:
run: |
npx -p @semantic-release/changelog -p @semantic-release/git -p @semantic-release/exec -p semantic-release semantic-release --dry-run
- name: Release
id: release
if: github.event.inputs.dry_run == 'false'
run: |
tags_before=$(git tag --list | wc -l)
npx -p @semantic-release/changelog -p @semantic-release/git -p @semantic-release/exec -p semantic-release semantic-release --github-assets "infra/feast-operator/dist/operator-e2e-tests"
# semantic-release exits 0 when there are no releasable commits; only a new tag means a release happened
if [ "$(git tag --list | wc -l)" -gt "$tags_before" ]; then
echo "released=true" >> "$GITHUB_OUTPUT"
else
echo "released=false" >> "$GITHUB_OUTPUT"
fi


update_stable_branch:
name: Update Stable Branch after release
if: github.event.inputs.dry_run == 'false'
if: github.event.inputs.dry_run == 'false' && needs.release.outputs.released == 'true'
runs-on: ubuntu-latest
needs: release
env:
Expand Down
Loading