Conversation
Motivation:
semantic-release exits 0 when it finds no releasable commits ("no new
version is released"). The release job therefore succeeds, and the
update_stable_branch job, which only depends on it and on dry_run ==
'false', still runs and force-resets the stable branch to the release
branch head, even though no release or tag was created.
Approach:
The release job now exposes a `released` output. The Release step
counts local tags before and after running semantic-release (the
checkout uses fetch-depth 0, and semantic-release creates the tag when
it releases) and sets released=true only if a new tag appeared.
update_stable_branch additionally requires released == 'true'.
Dry-run behaviour is unchanged. publish_versioned_docs is left as is.
Validation:
- Parsed release.yml with python yaml.safe_load (valid).
- Ran the tag-count shell logic in a scratch git repo: no new tag gives
released=false, a new tag gives released=true.
- Not run: the real release workflow (needs release tokens and a real
semantic-release run), so the end-to-end behaviour is reasoned from the
workflow and semantic-release's documented behaviour, not observed.
Report: feast-dev#5252
Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Assisted-by: claude-sonnet-5-5 (via Claude Code)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6910 +/- ##
=======================================
Coverage 48.04% 48.04%
=======================================
Files 427 427
Lines 53591 53591
Branches 7800 7800
=======================================
Hits 25749 25749
Misses 25986 25986
Partials 1856 1856
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
semantic-release exits 0 when there are no releasable commits, so the
releasejob succeeds andupdate_stable_branchstill force-resetsstablewithout a release. Thereleasejob now outputsreleased(true only if a new git tag was created by semantic-release), andupdate_stable_branchrequires it. Dry-run behaviour is unchanged.publish_versioned_docsis intentionally left alone.Which issue(s) this PR fixes:
Fixes #5252
Checks
git commit -s)Testing Strategy
Misc
Validated: YAML parses; the tag-count logic was run in a scratch git repo (no new tag -> false, new tag -> true). Not run: the actual release workflow (needs release tokens), so end-to-end behaviour is not observed.
Fixes #5252