Skip to content

Retry restore #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 3 commits into from
Jun 14, 2018
Merged

Retry restore #5187

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b57a20c
Retry restore
KevinRansom Jun 13, 2018
4e461c7
because reasons
KevinRansom Jun 13, 2018
5de8810
because not focussing
KevinRansom Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Retry restore
  • Loading branch information
@KevinRansom
KevinRansom committed Jun 13, 2018
commit b57a20ccca69603807ae645fcd9bc22fb5cf0535
11 changes: 6 additions & 5 deletions fcs/build.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,12 @@ Target "Restore" (fun _ ->
// We assume a paket restore has already been run
runDotnet __SOURCE_DIRECTORY__ "restore FSharp.Compiler.Service.sln -v n"
for p in [ "../packages.config" ] do
ExecProcess (fun info ->
info.FileName <- FullName @"./../.nuget/NuGet.exe"
info.WorkingDirectory <- FullName @"./.."
info.Arguments <- sprintf "restore %s -PackagesDirectory \"%s\" -ConfigFile \"%s\"" (FullName p) (FullName "./../packages") (FullName "./../NuGet.Config")) TimeSpan.MaxValue
|> assertExitCodeZero
let executeProcess () =

@forki forki Jun 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add a parameter "trials" and only retry 5 times

@KevinRansom KevinRansom Jun 13, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended it to only retry 1 time. I figured that would be sufficient to eliminate the annoyance. And ... how is your vacation?

ExecProcess (fun info ->
info.FileName <- FullName @"./../.nuget/NuGet.exe"
info.WorkingDirectory <- FullName @"./.."
info.Arguments <- sprintf "restore %s -PackagesDirectory \"%s\" -ConfigFile \"%s\"" (FullName p) (FullName "./../packages") (FullName "./../NuGet.Config")) TimeSpan.MaxValue
if executeProcess () <> 0 then executeProcess () |> assertExitCodeZero
)

Target "BuildVersion" (fun _ ->
Expand Down