Repository navigation
Retry restore - #5187
Merged
Merged
Retry restore#5187
Conversation
Contributor
|
Cool |
forki
approved these changes
Jun 13, 2018
forki
suggested changes
Jun 13, 2018
| info.WorkingDirectory <- FullName @"./.." | ||
| info.Arguments <- sprintf "restore %s -PackagesDirectory \"%s\" -ConfigFile \"%s\"" (FullName p) (FullName "./../packages") (FullName "./../NuGet.Config")) TimeSpan.MaxValue | ||
| |> assertExitCodeZero | ||
| let executeProcess () = |
Contributor
There was a problem hiding this comment.
I think you should add a parameter "trials" and only retry 5 times
Contributor
Author
There was a problem hiding this comment.
I intended it to only retry 1 time. I figured that would be sufficient to eliminate the annoyance. And ... how is your vacation?
Contributor
|
From all we learned in paket and FAKE over the years - make it retry
multiple times. ;-)
Kevin Ransom (msft) <notifications@github.com> schrieb am Mi., 13. Juni
2018, 07:36:
… ***@***.**** commented on this pull request.
------------------------------
In fcs/build.fsx
<#5187 (comment)>
:
> @@ -77,11 +77,12 @@ Target "Restore" (fun _ ->
// We assume a paket restore has already been run
runDotnet __SOURCE_DIRECTORY__ "restore FSharp.Compiler.Service.sln -v n"
for p in [ "../packages.config" ] do
- ExecProcess (fun info ->
- info.FileName <- FullName @"./../.nuget/NuGet.exe"
- info.WorkingDirectory <- FullName @"./.."
- info.Arguments <- sprintf "restore %s -PackagesDirectory \"%s\" -ConfigFile \"%s\"" (FullName p) (FullName "./../packages") (FullName "./../NuGet.Config")) TimeSpan.MaxValue
- |> assertExitCodeZero
+ let executeProcess () =
I intended it to only retry 1 time. I figured that would be sufficient to
eliminate the annoyance. And ... how is your vacation?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5187 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNAfQRMc_Thl49zg-ZzFItdALqhBMks5t8KT4gaJpZM4Ulakb>
.
|
Contributor
|
@forki You mean retry until the stack overflows? ;) |
Contributor
|
Dude! |
Contributor
Author
|
@forki, you guys are too funny :-) |
Contributor
|
fsprojects/Paket#3251 |
Contributor
Author
|
Let's see how this goes, if the failure still happens an annoying amount, we can retry multiple times, and perhaps try a delay and stuff. |
Contributor
Author
|
@forki,that is too funny. Software is hard .... |
Contributor
|
I agree that retrying 5 times would be good, may as well do it now rather than later |
brettfo
suggested changes
Jun 13, 2018
| info.FileName <- FullName @"./../.nuget/NuGet.exe" | ||
| info.WorkingDirectory <- FullName @"./.." | ||
| info.Arguments <- sprintf "restore %s -PackagesDirectory \"%s\" -ConfigFile \"%s\"" (FullName p) (FullName "./../packages") (FullName "./../NuGet.Config")) TimeSpan.MaxValue | ||
| if result <> 0 && count > 1 then executeProcess (count - 1) else 0 |
Member
There was a problem hiding this comment.
This should read ... else result so that if the 5 tries are exhausted the last error code is returned.
Contributor
Author
|
@brettfo Oh yeah …. |
brettfo
approved these changes
Jun 13, 2018
Contributor
|
Yay!
Kevin Ransom (msft) <notifications@github.com> schrieb am Do., 14. Juni
2018, 05:51:
… Merged #5187 <#5187>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5187 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNMfkUwvYhgDOB0bJsKuJBufCjIf4ks5t8d3egaJpZM4Ulakb>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry the restore