Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(S2): read an all-caps credential after a comma by default (#564) #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(S2): read an all-caps credential after a comma by default (#564) #577
Changes from 1 commit
fc258808d1abb538d4189b26beffb783f664ba12ba3e03c08a16927cbbe6b0f07c5662d7f4dac2479eab71fea58File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
…letter (Derek) The capital-then-lowercase test leaked a whole class: any capitalized prefix glued to a surname written in capitals supplies the pair ('LLOYD FitzGERALD, RONALD', 'PAOLO DeVITO, MARCO', 'JEAN LaFLEUR, PIERRE', 'DICK VanDYKE, JOHN', 'PAUL DuBOIS, JEAN', 'JEAN St-PIERRE, MARC', 'LLOYD SMITH-McDONALD, RONALD'), as does ß ('MÜLLER WEIß, HANS'); each lost its given name, the Mc/Mac skip being one member of the class. It also missed titlecase digraphs ('Džokić Ljubić, XYZ') and cost a frame per letter. Derek's criterion: a word carries the contrast if it holds a capital and its last letter is lowercase, a trailing ß aside. A surname written in capitals ends in one whatever is glued in front, so no prefix list is needed; 'McDonald', 'Džokić' and decomposed accents pass. Two C-level checks, so the per-letter cost is gone (a record with lowercase particles is a constant +22 over master at any length). Measured against the previous commit: exactly those eight prefixes and Džokić moved, no corpus or case-table name, OFF still equal to master. rules.md#C1, the Policy docstring, customize.rst and the release log drop the false universal; decisions.md#S2 records the chosen option's own leaks and the accepted hyphenated case; case rows and a broader parametrized test pin it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.