Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(S2): read an all-caps credential after a comma by default (#564) #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(S2): read an all-caps credential after a comma by default (#564) #577
Changes from 1 commit
fc258808d1abb538d4189b26beffb783f664ba12ba3e03c08a16927cbbe6b0f07c5662d7f4dac2479eab71fea58File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
The previous commit tested the last character, so a name typed with decomposed accents ending in an accented letter lost the contrast ('José André, XYZ', 'Lê Thị Hà, XYZ', 'René Noé, XYZ' read given where their composed spellings read suffix), as did "Jones'", 'Smith2' and a glued 'Smith)'. written_as_a_name now composes the word (NFC), passes over trailing non-letters, and passes over a lowercase letter with no single capital form (ß, ĸ), which generalizes the ß rule. One call, no generator. Measured against the previous commit: the four decomposed-accent names and 'JOHN Smith)' regain the contrast and the ĸ record keeps its given name; nothing else moves, and OFF equals master on 4292 inputs. Also from the review: rules.md#C1 states the last-letter reading and pins 'MÜLLER WEIß, HANS'; decisions.md#S2 records the true blast radius of the previous commit (seven prefixes plus ß and Džokić, and 'JOHN O'NEILL's' / 'JEAN-pierre DUPONT' / 'MARY-kate OLSEN', now accepted costs) with a recompute recipe; the cost prose says what it is, about four frames per word before the comma and constant in a word's letters; the fix(#564) ledger comments drop the wording decisions.md calls wrong. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.