docs(C1): a particle that is also a credential counts in the run (#554) - #574
Merged
Merged
Conversation
Settles #554 as option (a), the shipped behavior; no parse moves. After a comma, a word of both the particle and the unambiguous suffix vocabulary (vd, mc) counts as a suffix word in C1's run test, while S2's company still refuses to let it speak for the word behind it. These are two questions, not one answered twice: run membership asks what the word is, company asks whether a particle can vouch for the word P2 joins it to. Written in one case, where no capitals speak, the part reads as the credential run (JOHN SMITH, VD MA -> suffix VD MA, reported), which is the reading a reader takes; (b) would give that input a one-word listing form with no given name. rules.md#C1 gains the clause and two examples; decisions.md#C1 records the decision. The examples enter the rules corpus, so the #544 run rule gains both names in the 2.0.0-2.3.0 ledgers and the moved corpus claims are re-recorded. The gate exits 0 at every baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 45 45
Lines 3990 4017 +27
=======================================
+ Hits 3945 3972 +27
Misses 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…scope - rules.md#C1: the clause now leads with what it decides (a word's particle reading does not take it out of the run) and names the two runs plainly; "such a part" gets an explicit antecedent. - New C1 examples pin the uniform-case report and the clause's scope: 'John Smith, Jr vd' is silent, 'John Smith, Jr do' reports (do is a word of the ambiguous class, so the clause does not reach it). - decisions.md#C1: PR #552's split was an intermediate state, never released; 1.4.0 read these names as (a) does (verified against the wheel); do's membership shown by a recompute; shorter Open: handle. - Ledgers: comments carry the "unambiguous" qualifier and quote the new clause; 'John Smith, Jr do' joins the #544 run rule at 2.0.0-2.3.0, with each baseline's own reading. Moved corpus claims re-recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- decisions.md#C1: the 'Smith vd Ma, John' split was not only an intermediate state of #552 -- 2.2.0 and 2.3.0 shipped it and #530 removed it this cycle (measured against the wheels). - The Open: handle names the shapes #573 actually covers: before a comma and after a family comma, not after a suffix comma. - 'John Smith, Jr do' is not a boundary of the particle clause: do is still a run member and the part still flips; only the report differs. The `· boundary` label and the ledgers' "boundary" wording go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #554 by choosing option (a), which is what the parser already does. No parse changes.
After a comma, a word that is both a particle and unambiguous suffix vocabulary (
vd,mc) still counts as a suffix word in C1's run test. S2's company rule still won't let that word vouch for the word behind it. The issue treated this as two rules giving different answers to one question. It's actually two different questions:vdis unambiguous suffix vocabulary.Evidence. Neither reading of
vd Maafter a comma is realistic, so the mixed-case form decides nothing. Uniform case is where the decision matters, because there are no capitals for S2 to read and the vocabulary is the only signal. There the part reads as the credential run, which is the reading a person would take:John Smith, vd Mavd Ma, reportssuffix-or-nameJOHN SMITH, VD MAVD MA, reportssuffix-or-namejohn smith, vd mavd ma, reportssuffix-or-namemcreads the same way in every casing. This is also what 1.4.0 read; 2.0.0 through 2.3.0 read the whole name as the family. Option (b) would have needed a particle exception in C1 and in #567's paired-initials check. Its result would be the familyJOHN SMITH VD MAwith no given name. #563's site (García Márquez, vd G.J.) reads exactly likePhD G.J., so it needs no change.Changes
rules.md#C1: a clause saying a word's particle reading doesn't take it out of the run. It is scoped to the unambiguous suffix vocabulary, which is exactly{vd, mc}. New examples pin the reading and the report forvd Ma/VD MA, and contrastJohn Smith, Jr vd(silent) withJohn Smith, Jr do(reports, becausedois in the ambiguous half and already counts as a class word).decisions.md#C1: a dated entry for Should a particle that is also a credential (vd,mc) count in a credential run after a comma? #554 with the evidence and a recompute recipe. It points to Why doesSMITH VD MA, JOHNread familySMITH MAwithVDas a suffix? #573.John Smith, PhD MEngreads firstPhD, lastJohn Smith#544 run rule in the 2.0.0–2.3.0 ledgers gainsJohn Smith, vd Ma,JOHN SMITH, VD MAandJohn Smith, Jr do, with each baseline's own reading in the comment, and the_CORPUS_CLAIMSentries they move are re-recorded.Follow-up
#573 covers the uniform-case defects found while measuring this. In
SMITH VD MA, JOHN,VDis pulled out from between the family words. InDOE, JANE PHD VD MA,VDlands in front of the family name. InSMITH, VD MA,VDstays behind in the family. That issue also covers #554's aside aboutDoe, Jane PhD vd Magoing into middle without a report.Verification
ruff checkis clean.design-docs-reviewerpass before the PR, then/pr-review-toolkit:review-pr(code, comments, tests), then a second review of the fix commit. No parse claim was wrong. The rounds fixed the clause's wording and scope, added the pinning examples, and corrected one history claim: theSmith vd Ma, Johnsplit shipped in 2.2.0 and 2.3.0 and was fixed by Case and shape decide a bare ambiguous credential acronym (#289, #516) #530, not only inside fix(#544): a credential run keeps its ambiguous members #552.🤖 Generated with Claude Code