Skip to content

Re-add tox environments - #248

Merged
aaronliu0130 merged 1 commit into
cpplint:developfrom
jayvdb:tox-envs
Feb 4, 2024
Merged

aaronliu0130 merged 1 commit into
cpplint:developfrom
jayvdb:tox-envs

Conversation

@jayvdb

@jayvdb jayvdb commented Feb 4, 2024 •

Copy link
Copy Markdown
Member

These were removed in be2a415

These are necessary to allow testing on those Python versions. They do not cause CI to test them all.

@aaronliu0130

Copy link
Copy Markdown
Member

To put it simply: Why would we need CI to test on all of these environments? Just the oldest, the latest and pypy (which happens to be in the middle) would be enough. See 2bd1536. Having so much wastes a lot of actions runtime. Or do you mean to make us only test these when we’re locally testing and not in actions?

@jayvdb

jayvdb commented Feb 4, 2024

Copy link
Copy Markdown
Member Author

I wrote "They do not cause CI to test them all."

Also look at the CI for this PR.

@aaronliu0130

Copy link
Copy Markdown
Member

I apologize, I misread that. However, you don't need these to allow testing. I can do tox -e py311 on my machine without that in the envlist. I'm pretty sure the envlist is only for the list of environments to run when you just do tox alone.

@jayvdb

jayvdb commented Feb 4, 2024

Copy link
Copy Markdown
Member Author

Yes, you can run these envs without them being specified, however this list indicates which ones are supported, and they all should be run if testing all supported environments locally.

@aaronliu0130
aaronliu0130 merged commit 26dacc6 into cpplint:develop Feb 4, 2024
@jayvdb
jayvdb deleted the tox-envs branch February 5, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants