Skip to content

Fix Windows tests and add Windows CI - #247

Merged
jayvdb merged 1 commit into
cpplint:developfrom
jayvdb:win
Feb 23, 2024
Merged

jayvdb merged 1 commit into
cpplint:developfrom
jayvdb:win

Conversation

@jayvdb

@jayvdb jayvdb commented Feb 4, 2024 •

Copy link
Copy Markdown
Member

#248 is first in this series.

@jayvdb

jayvdb commented Feb 4, 2024

Copy link
Copy Markdown
Member Author

Tests are hanging on some windows versions of Python.

@jayvdb
jayvdb force-pushed the win branch 3 times, most recently from 7fe1dbb to 6c11f8a Compare February 4, 2024 06:18
Comment thread tox.ini Outdated
@aaronliu0130

Copy link
Copy Markdown
Member

What would happen if the envlist in tox only contains the three envs we want?

@aaronliu0130 aaronliu0130 changed the title Add Windows CI Fix Windows tests and add Windows CI Feb 4, 2024
@jayvdb
jayvdb requested a review from tkruse February 4, 2024 22:28
@aaronliu0130

Copy link
Copy Markdown
Member

You don't need to force push; you can just click on the dropdown next to "merge" and click on "squash and merge" when everything's finished.

@aaronliu0130 aaronliu0130 mentioned this pull request Feb 4, 2024
Comment thread .github/workflows/ci.yml
@aaronliu0130 aaronliu0130 linked an issue Feb 17, 2024 that may be closed by this pull request
@jayvdb jayvdb mentioned this pull request Feb 18, 2024
@jayvdb
jayvdb merged commit 6f9c205 into cpplint:develop Feb 23, 2024
@jayvdb
jayvdb deleted the win branch February 23, 2024 08:52
@aaronliu0130

aaronliu0130 commented Feb 23, 2024 •

Copy link
Copy Markdown
Member

@jayvdb Could we make pytest output unverbose again? It's currently a bit more of a pain to navigate in CI's output without much benefit that I can see.

@jayvdb

jayvdb commented Feb 24, 2024

Copy link
Copy Markdown
Member Author

Because when tests hang in CI, pytest doesnt show which test has hung. The best way to see which test hung is to know which test was previous to the hang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Windows tests

3 participants