Skip to content

Prevent unneed LM calls during /run #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ErichBSchulz wants to merge 11 commits into from
Closed

Prevent unneed LM calls during /run #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
58bd6c2
docs: add debug plan
ErichBSchulz Oct 29, 2025
96d6fa3
docs: update debug plan with new principles and hypothesis
ErichBSchulz Oct 29, 2025
5541f0e
feat: add debug counter
ErichBSchulz Oct 29, 2025
64c6fab
docs: update debug plan with user feedback
ErichBSchulz Oct 29, 2025
dccf5cd
feat: add diagnostic logging for input processing
ErichBSchulz Oct 29, 2025
75693dc
fix: set placeholder during command execution to prevent input race
ErichBSchulz Oct 29, 2025
1d06783
feat: add detailed logging for command execution and input conditions
ErichBSchulz Oct 29, 2025
c7757a7
fix: prevent race condition by setting placeholder before processing …
ErichBSchulz Oct 29, 2025
0638c7f
fix: remove distracting spinner during user prompts
ErichBSchulz Oct 29, 2025
f6dcda5
chore: remove debugging code and logging statements
ErichBSchulz Oct 29, 2025
010d439
delete the plan and notes
ErichBSchulz Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aider/coders/base_coder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,11 +1140,12 @@ async def _run_patched(self, with_message=None, preproc=True):
self.io.stop_spinner()

if user_message and self.run_one_completed and self.compact_context_completed:
if self.commands.is_command(user_message):
self.io.placeholder = "Running command..."
processing_task = asyncio.create_task(
self._processing_logic(user_message, preproc)
)
# Start spinner for processing task
self.io.start_spinner("Processing...")
user_message = None # Clear message after starting task
except KeyboardInterrupt:
if processing_task:
Expand Down
18 changes: 15 additions & 3 deletions aider/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ def matching_commands(self, inp):
async def run(self, inp):
if inp.startswith("!"):
self.coder.event("command_run")
return await self.do_run("run", inp[1:])
self.io.placeholder = "Running command..."
try:
return await self.do_run("run", inp[1:])
finally:
self.io.placeholder = ""

res = self.matching_commands(inp)
if res is None:
Expand All @@ -325,11 +329,19 @@ async def run(self, inp):
if len(matching_commands) == 1:
command = matching_commands[0][1:]
self.coder.event(f"command_{command}")
return await self.do_run(command, rest_inp)
self.io.placeholder = f"Running {command}..."
try:
return await self.do_run(command, rest_inp)
finally:
self.io.placeholder = ""
elif first_word in matching_commands:
command = first_word[1:]
self.coder.event(f"command_{command}")
return await self.do_run(command, rest_inp)
self.io.placeholder = f"Running {command}..."
try:
return await self.do_run(command, rest_inp)
finally:
self.io.placeholder = ""
elif len(matching_commands) > 1:
self.io.tool_error(f"Ambiguous command: {', '.join(matching_commands)}")
else:
Expand Down