Skip to content

Prevent unneed LM calls during /run - #67

Closed
ErichBSchulz wants to merge 11 commits into
cecli-dev:mainfrom
ErichBSchulz:bug65
Closed

ErichBSchulz wants to merge 11 commits into
cecli-dev:mainfrom
ErichBSchulz:bug65

Conversation

@ErichBSchulz

Copy link
Copy Markdown

Hi Dustin,

me and gemini had a go at this. Its not perfect but it is better!

let me know what you think.

ErichBSchulz and others added 11 commits October 29, 2025 17:11
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
…task

Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
@ErichBSchulz

Copy link
Copy Markdown
Author

ie relating to #65

@dwash96

dwash96 commented Oct 30, 2025

Copy link
Copy Markdown
Collaborator

Very nice, always appreciate contribution! I think I will adapt this to detect the run command specifically so it doesn't trigger a new processing task immediately since that's what ultimately calls the LLM. This current logic would actually detect all of the slash commands and output the running message for them

@ErichBSchulz

Copy link
Copy Markdown
Author

Thanks Dustin! yes this is bit rough - I wasn't even sure how this new async approach's goals are so glad you can tweak this. I won't be offended if reject this PR!

@ErichBSchulz

Copy link
Copy Markdown
Author

Arg and actually this is only a partial fix. My Gemini API still getting hammered by unwanted lm calls when it asks to add files.

@dwash96

dwash96 commented Nov 2, 2025

Copy link
Copy Markdown
Collaborator

The 0.88.4 PR should address this, the gist of it is that to prevent confirmations from being treated as prompt inputs, I added acknowledgement logic so that we simply skip propagating the message for the turn of the main loop immediately after a confirmation

@dwash96 dwash96 closed this Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants