Repository navigation
Fix #933 URLConnection to invalid HTTP URL is not detected as failure - #936
Merged
Merged
Conversation
…failure When the httpConnection is invalid, the application does not detect it, and it saves an empty (precisely a 20 bytes) file. This fix detects when the connection is invalid or the file has no contents. Related to biojava#703
josemduarte
requested changes
Jun 17, 2021
josemduarte
left a comment
josemduarte
left a comment
Contributor
There was a problem hiding this comment.
Thanks! One comment about the error message
Contributor
|
@aalhossary , we are having some trouble with the CI tests. Could you try pushing an empty commit ( |
jnbdz
pushed a commit
to jnbdz/biojava
that referenced
this pull request
Aug 2, 2026
Fix biojava#933 URLConnection to invalid HTTP URL is not detected as failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the httpConnection is invalid, the application does not detect it, and it saves an empty (precisely a 20 bytes) file.
This fix detects when the connection is invalid or the file has no contents.
Related to #703
Adding a flag to be successful only when at least one byte is successfully read from the server