Skip to content

URLConnection to invalid HTTP URL is not detected as a failure #933

Closed

Description

@aalhossary

TestDownloadChemCompProvider.testIfWeCachedGarbageWeCanDetectIt() still fails to detect when the target URL is invalid or the file has no contents. Instead of deleting the local cache file, a 20 bytes file (effectively an empty one) is saved.
Related to #703

Activity

  1. self-assigned this
    on Jun 16, 2021
  2. josemduarte commented on Jun 16, 2021

    @josemduarte
    Contributor

    Thanks @aalhossary . Actually I noticed this and fixed it in master a few days ago. Are you in latest master?

  3. aalhossary commented on Jun 16, 2021

    @aalhossary
    MemberAuthor
  4. added a commit that references this issue on Jun 16, 2021
    0a66b4e
  5. added a commit that references this issue on Jun 24, 2021
    50b4372
  6. added 2 commits that reference this issue on Aug 2, 2026
    df586e8
    3462fc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions