You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
URLConnection to invalid HTTP URL is not detected as a failure #933
TestDownloadChemCompProvider.testIfWeCachedGarbageWeCanDetectIt() still fails to detect when the target URL is invalid or the file has no contents. Instead of deleting the local cache file, a 20 bytes file (effectively an empty one) is saved.
Related to #703
Yes I am. I noticed it when I was running the tests to building a jar before submitting another fix.
To fix it I added a flag that will be true only if a file could be actually read.
I will create a PR soon.
Amr
Activity
josemduarte commentedon Jun 16, 2021
Thanks @aalhossary . Actually I noticed this and fixed it in master a few days ago. Are you in latest master?
aalhossary commentedon Jun 16, 2021
Fix biojava#933 URLConnection to invalid HTTP URL is not detected as …
Merge pull request #936 from aalhossary/amr/fix933
Fix biojava#933 URLConnection to invalid HTTP URL is not detected as …
Merge pull request biojava#936 from aalhossary/amr/fix933