Skip to content

Appveyor - Create fat-binary gems and test - #176

Closed
MSP-Greg wants to merge 1 commit into
bcrypt-ruby:masterfrom
MSP-Greg:av-gem-build-test
Closed

MSP-Greg wants to merge 1 commit into
bcrypt-ruby:masterfrom
MSP-Greg:av-gem-build-test

Conversation

@MSP-Greg

Copy link
Copy Markdown

Two jobs on Appveyor, 64 bit & 32 bit

  1. Builds Windows fat binary gems - currently for 2.0 thru 2.5. 64 bit also includes trunk.
  2. Loops thru all Ruby versions, installs the gem, and tests.
  3. Tests are shown on the Appveyor job test tab.
  4. A run on my fork took 5:16.
  5. Gems and a 7z of test logs are saved as artifacts
  6. Current commit info (date, short SHA, summary) is stored in gemspec as metadata.

@MSP-Greg

MSP-Greg commented Jun 22, 2018 •

Copy link
Copy Markdown
Author

Thought Appveyor was active here. The job in my fork is at:

https://ci.appveyor.com/project/MSP-Greg/bcrypt-ruby/build/1

Some benefits of testing on Appveyor:

  1. Trunk build Is fully tested. Only the most recent passing build will be used. The ruby-head commit (svn 63718) that the Travis build used for this PR actually failed on ruby/ruby.
  2. Ruby versions 2.4 and forward use gcc 7.3.0, which I believe is much newer than the current compilers on Travis. Appveyor has shown issues in Ruby trunk testing that weren't caught on Travis.
  3. Did I mention that this took less time to complete than the respective Travis build? You might as well build fat-binary gems while you're waiting...

@MSP-Greg

Copy link
Copy Markdown
Author

The question everyone wants the answer to - what needs to be done when Ruby 2.6 is released?

The answer - Nothing. Wait for Appveyor to add it to their images. Ruby 2.5 took about a month. I suspect they'll add future versions a bit quicker in the future...

@MSP-Greg

Copy link
Copy Markdown
Author

@tjschuck @tenderlove @larskanis

If any of you have the time to read it and reply, I've added an issue at the repo containing the shared code for the topic of Windows pre-compiled gems and testing on Appveyor.

MSP-Greg/av-gem-build-test#1

Thanks, Greg

@tjschuck

Copy link
Copy Markdown
Collaborator

Per #173 and #174, I think the correct way forward is to drop the precompiled binaries altogether. (For what it's worth, this would also be a step back in our fat-binary support in the bcrypt gem — I currently precompile binaries for Windows all the way back to 1.8.7 via https://github.com/tjschuck/rake-compiler-dev-box.)

Thanks for your work on this!

@tjschuck tjschuck closed this Jun 27, 2018
@MSP-Greg
MSP-Greg deleted the av-gem-build-test branch July 13, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants