Repository navigation
No more Windows fat binaries (or precompiled binaries at all) - #174
Merged
Merged
Conversation
|
Looks good! You're still putting effort into Ruby-1.8.7? Maybe you could drop old Ruby versions with bcrypt-4.0? |
Collaborator
Author
|
@larskanis I'm fine with dropping 1.8 if we have to for some reason, but as long as it's possible to somewhat trivially support 1.8, I'd rather keep it alive strictly because this is a security-related library. If someone's dealing with some 1.8 legacy app, I don't want them to jump to SHA-1 just because the latest bcrypt-ruby doesn't install easily 😅 That said, emphasis on the "somewhat trivially" part of it. For now, there hasn't been a huge cost to continue supporting 1.8. |
This was referenced Jun 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tenderlove @larskanis Fixes #173.
We will now no longer provide compiled binaries at all, and particularly not Windows fat binaries. The AppVeyor config has been updated to now actually compile the lib and run the tests, not just install the gem like we were previously testing.