Skip to content

Add babel/no-empty eslint rule #18009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JLHwung wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add babel/no-empty eslint rule #18009

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2eef322
feat(eslint-plugin): add configs.all / recommended
JLHwung Apr 28, 2026
9eaeb53
test: add index.tst.ts
JLHwung Apr 28, 2026
ca030ff
fix merge issues
JLHwung May 21, 2026
92fbfba
test: update tst tests
JLHwung May 21, 2026
f5d6b69
feat(eslint): allow empty block in do expression
JLHwung Apr 21, 2026
c3ca23d
no-empty now also reports suggestions
JLHwung Apr 22, 2026
59411a5
feat: add no-empty to recommended presets
JLHwung May 21, 2026
73c199a
add integration test case
JLHwung Jul 17, 2026
44cd45a
ci: downgrade @eslint/js in eslint 9.0 test
JLHwung Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add no-empty to recommended presets
  • Loading branch information
@JLHwung
JLHwung committed Jul 17, 2026
commit 59411a58ed7bcfc742857b653a66d170f631982c
2 changes: 2 additions & 0 deletions eslint/babel-eslint-plugin/src/configs/all.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ export const name = "babel/eslint-plugin/all";
export const rules: Record<string, SeverityString> = {
// ESLint core rules
"new-cap": "off",
"no-empty": "off",
"no-undef": "off",
"no-unused-expressions": "off",

// babel-eslint-plugin rules
"babel/new-cap": "error",
"babel/no-empty": "error",
"babel/no-undef": "error",
"babel/no-unused-expressions": "error",
};
3 changes: 3 additions & 0 deletions eslint/babel-eslint-plugin/src/configs/recommended.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,8 @@ import type { SeverityString } from "../types.ts";
export const name = "babel/eslint-plugin/recommended";
export const rules: Record<string, SeverityString> = {
// ESLint core rules
"no-empty": "off",

// babel-eslint-plugin rules
"babel/no-empty": "error",
};
2 changes: 1 addition & 1 deletion eslint/babel-eslint-plugin/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const meta: ESLint.Plugin["meta"] = {
version: PACKAGE_JSON.version,
};

type Rules = "new-cap" | "no-undef" | "no-unused-expressions";
type Rules = "new-cap" | "no-empty" | "no-undef" | "no-unused-expressions";

const rules: Record<Rules, Rule.RuleModule> = {
"new-cap": newCap,
Expand Down