Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61937 |
|
commit: |
@babel/no-empty eslint rulebabel/no-empty eslint rule
JLHwung
force-pushed
the
add-babel-no-empty-eslint-rule
branch
from
July 15, 2026 18:13
0fb5fbf to
16ff9cd
Compare
nicolo-ribaudo
approved these changes
Jul 16, 2026
liuxingbaoyu
approved these changes
Jul 16, 2026
Contributor
Author
|
The Docs PR is ready: babel/website#3227, ptal. |
JLHwung
force-pushed
the
add-babel-no-empty-eslint-rule
branch
from
July 17, 2026 18:14
16ff9cd to
5e4f3c5
Compare
JLHwung
force-pushed
the
add-babel-no-empty-eslint-rule
branch
from
July 17, 2026 18:58
5e4f3c5 to
73c199a
Compare
Contributor
Author
|
New integration test cases show how |
JLHwung
force-pushed
the
add-babel-no-empty-eslint-rule
branch
from
July 17, 2026 21:10
b9c8cd8 to
44cd45a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #17956.
In this PR we add a new
@babel/no-emptyrule to replace the builtin ESLint rule. The new rule allows empty block of the do expression asdo{}is shorter thanvoid 0andasync do{}is shorter thanPromise.resolve(void 0).We also add
@babel/no-emptyto the recommended preset asno-emptyis in the recommended preset of@eslint/js.