This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Repository navigation
fix(@schematics/update): respect caret and tilde ranges - #884
Merged
Merged
Conversation
clydin
reviewed
May 10, 2018
| map(tree => { | ||
| const packageJson = JSON.parse(tree.readContent('/package.json')); | ||
| // This one should not change because 1.1.0 was already satisfied by ^1.0.0. | ||
| expect(packageJson['dependencies']['@angular-devkit-tests/update-base']).toBe('^1.0.0'); |
Member
There was a problem hiding this comment.
wouldn't this cause 1.1.0 to not be used due to an existing lock file?
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, that behaviour is intentional:
devkit/packages/schematics/update/update/index.ts
Lines 535 to 538 in e6379b1
At this point, the new version is already installed though, and presumably the lockfile is updated.
Member
There was a problem hiding this comment.
OK. Could envision some issue reports in the future regarding the behavior though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix angular/angular-cli#10356