Skip to content

Do not pin versions on ng update #10356

Closed

Description

@cyrilletuzi

Versions

cli 6.0.0-rc.4

Repro steps

From an Angular 5 project:

  • update the CLI to v6 and migrate
  • ng update @angular/core --next

Observed behavior

Pinned versions in package.json:

"@angular/compiler": "6.0.0-rc.5",
"@angular/core": "6.0.0-rc.5",
"typescript": "2.7.2"
...

Desired behavior

Keep semantic versionning in package.json:

"@angular/compiler": "^6.0.0-rc.5",
"@angular/core": "^6.0.0-rc.5",
"typescript": "~2.7.2"
...

Mention any other details that might be useful (optional)

Pinned versions mean we can't do anymore minor/patch updates of the whole project simply with npm update and goes against semver.

It's not the role of the CLI to pin the versions. It's the role of the package manager, and as Angular 6 and CLI 6 require Node >= 8.9 and npm >= 5.5, it means the job is already done in a proper way by the package-lock.json.

Activity

  1. added this to the v6.0.0 milestone on Apr 16, 2018
  2. hansl commented on Apr 23, 2018

    @hansl
    Contributor

    I'm pretty sure this is a dupe as we've talked about it internally, but can't find the original issue so marking this as required.

  3. added
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    P5The team acknowledges the request but does not plan to address it, it remains open for discussion
    and removed
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    on Apr 23, 2018
  4. angular-automatic-lock-bot commented on Sep 8, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  5. locked and limited conversation to collaborators on Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussion

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions