Skip to content

refactor(forms): modernize value accessor integration tests #71140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MeAkib wants to merge 1 commit into
base: main
Choose a base branch
from
+194 −175
Open

refactor(forms): modernize value accessor integration tests #71140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/forms/test/reactive_integration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ import {
ValueChangeEvent,
} from '../src/model/abstract_model';

import {MyInput, MyInputForm} from './value_accessor_integration_spec';
import {MyInputForm} from './value_accessor_integration_spec';

// Produces a new @Directive (with a given selector) that represents a validator class.
function createValidatorClass(selector: string) {
Expand Down Expand Up @@ -820,7 +820,7 @@ describe('reactive forms integration tests', () => {
});

it('should not add disabled attribute to custom controls when disable() is called', async () => {
const fixture = initTest(MyInputForm, MyInput);
const fixture = TestBed.createComponent(MyInputForm);
const control = new FormControl('some value');
fixture.componentInstance.form = new FormGroup({login: control});
await fixture.whenStable();
Expand Down
4 changes: 2 additions & 2 deletions packages/forms/test/template_integration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import {
Validator,
} from '../index';

import {NgModelCustomComp, NgModelCustomWrapper} from './value_accessor_integration_spec';
import {NgModelCustomWrapper} from './value_accessor_integration_spec';

describe('template-driven forms integration tests', () => {
useAutoTick();
Expand Down Expand Up @@ -1383,7 +1383,7 @@ describe('template-driven forms integration tests', () => {
});

it('should disable a custom control if disabled attr is added', async () => {
const fixture = initTest(NgModelCustomWrapper, NgModelCustomComp);
const fixture = TestBed.createComponent(NgModelCustomWrapper);
Comment thread
JeanMeche marked this conversation as resolved.
fixture.componentInstance.name = 'Nancy';
fixture.componentInstance.isDisabled = true;
await fixture.whenStable();
Expand Down
Loading
Loading