Conversation
Migrate the value accessor integration spec to current Angular patterns: - use standalone fixtures that import only the forms module they need, instead of declaring them through an `initTest` helper - replace `*ngFor`/`*ngIf` with `@for`/`@if` - use `inject()` instead of constructor injection The reactive and template integration specs reuse two of these fixtures and are updated to create them directly.
JeanMeche
reviewed
Oct 2, 2026
|
|
||
| it('should disable a custom control if disabled attr is added', async () => { | ||
| const fixture = initTest(NgModelCustomWrapper, NgModelCustomComp); | ||
| const fixture = TestBed.createComponent(NgModelCustomWrapper); |
Member
There was a problem hiding this comment.
That looks sus, the component is not standalone
Contributor
Author
There was a problem hiding this comment.
NgModelCustomWrapper isn鈥檛 defined in this file; it鈥檚 imported from value_accessor_integration_spec.ts. This PR makes it standalone there by having it import FormsModule and NgModelCustomComp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the value accessor integration spec to current Angular patterns:
initTesthelper*ngFor/*ngIfwith@for/@ifinject()instead of constructor injectionThe reactive and template integration specs reuse two of these fixtures and are updated to create them directly.