Skip to content

.NET: fix CA1873 in GitHubCopilotAgent by using LoggerMessage source generator #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alliscode wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

.NET: fix CA1873 in GitHubCopilotAgent by using LoggerMessage source generator #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: resolve CA1873 in GitHubCopilotAgent by using LoggerMessage sour… 
…ce generator

Replace the direct logger.LogWarning() call (which eagerly evaluates
string.Join()) with a [LoggerMessage]-generated extension method in
GitHubCopilotAgentLogMessages.cs.

Fixes build error:
  GitHubCopilotAgent.cs(580,13): error CA1873: Evaluation of this argument
  may be expensive and unnecessary if logging is disabled

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@alliscode
alliscode and Copilot committed Jun 30, 2026
commit 725e72964a36142d698a52b57c2af0a3f7c94b1a
10 changes: 7 additions & 3 deletions dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,9 +577,13 @@ private AgentResponseUpdate ConvertToAgentResponseUpdate(SessionEvent sessionEve
// Warn so the developer knows the ApprovalRequiredAIFunction marker(s) will not be automatically gated.
if (sessionConfig.Hooks?.OnPreToolUse is not null)
{
logger.LogApprovalGatingSkippedDueToCustomHook(
approvalRequiredToolNames.Count,
string.Join(", ", approvalRequiredToolNames));
if (logger.IsEnabled(LogLevel.Warning))
{
logger.LogApprovalGatingSkippedDueToCustomHook(
approvalRequiredToolNames.Count,
string.Join(", ", approvalRequiredToolNames));
}

return sessionConfig;
}

Expand Down
Loading