Repository navigation
Conversation
…ce generator Replace the direct logger.LogWarning() call (which eagerly evaluates string.Join()) with a [LoggerMessage]-generated extension method in GitHubCopilotAgentLogMessages.cs. Fixes build error: GitHubCopilotAgent.cs(580,13): error CA1873: Evaluation of this argument may be expensive and unnecessary if logging is disabled Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alliscode
force-pushed
the
bentho/fix-ca1873-github-copilot-logger
branch
from
June 30, 2026 02:05
ef12b58 to
725e729
Compare
alliscode
pushed a commit
that referenced
this pull request
Sep 30, 2026
…osoft#8201) (microsoft#8284) * Python: add public TypedDict for AgentExecutor checkpoint state (microsoft#8201) Expose AgentExecutorCheckpointState / AgentSessionCheckpointState, validate restore field types, and cover partial/malformed/forward-compatible payloads. * fix(checkpoint): address microsoft#8284 review on session TypedDict ownership (#1) - Define AgentSessionDict on AgentSession (to_dict return) so the shape is not duplicated in AgentExecutor; keep AgentSessionCheckpointState as alias. - Include ServiceSessionId mapping in service_session_id. - Type on_checkpoint_restore as AgentExecutorCheckpointState only. - Sync root stub exports (__init__.pyi) with runtime __all__. * fix(checkpoint): validate AgentExecutor restore element types (microsoft#8284) Enforce Message/Content element types, string pending-request keys, and required agent_session.session_id so malformed checkpoints fail at restore. * fix(checkpoint): validate AgentSessionDict fields on restore - Validate agent_session.state / service_session_id types - Raise WorkflowCheckpointException when session restore fails - Drop unshipped AgentSessionCheckpointState alias; use AgentSessionDict * fix(checkpoint): keep session/executor checkpoint payloads as dict TypedDict schemas remain public for documentation and validation, but to_dict and on_checkpoint_save/restore stay dict[str, Any] so subclasses, samples, and pyright stay compatible. * fix(checkpoint): keep AgentSessionDict optional keys under postponed annotations Use a required base plus total=False subclass, stop exporting AgentSessionDict from the public package root, and tighten AgentExecutor restore validation with walrus checks. --------- Co-authored-by: minelhi <3417378192@qq.com> Co-authored-by: LI <2484593937@qq.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com> Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The release build was failing with CA1873 analyzer errors in
GitHubCopilotAgent.cs:The violation was caused by
string.Join(", ", approvalRequiredToolNames)being passed as an argument tologger.LogWarning(). This string concatenation is evaluated eagerly at the call site, even when theWarninglog level is disabled — exactly the scenario CA1873 guards against.Description & Review Guide
What are the major changes?
GitHubCopilotAgentLogMessages.cswith a[LoggerMessage]-generated extension methodLogApprovalGatingSkippedDueToCustomHook, following the established pattern used throughout the codebase (e.g.ChatClientAgentLogMessages.cs).logger.LogWarning(...)call inGitHubCopilotAgent.ConfigureApprovalHookwith the new source-generated method, wrapped in anif (logger.IsEnabled(LogLevel.Warning))guard so the expensivestring.Joinis only evaluated when the warning level is actually active.What is the impact of these changes?
The CA1873 build error is resolved across all target frameworks (net8.0, net9.0, net10.0). No behavioral change — the log message content and level are identical.
What do you want reviewers to focus on?
The
IsEnabledguard at the call site is necessary in addition to the[LoggerMessage]method because the source-generated method's internalIsEnabledcheck does not prevent eager argument evaluation at the call site. CA1873 fires on the argument expression itself.Related Issue
Fixes #
Contribution Checklist