Skip to content

Seekbar label translatability - #792

Merged
joedolson merged 2 commits into
ableplayer:developfrom
DuaelFr:seekbar-label-translatability
Oct 4, 2026
Merged

Seekbar label translatability#792
joedolson merged 2 commits into
ableplayer:developfrom
DuaelFr:seekbar-label-translatability

Conversation

@DuaelFr

@DuaelFr DuaelFr commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Not all languages build their sentences the same. For example, **audio** timeline is translated Barre de progression **audio** in French. To allow these translations to be as accurate as possible, we cannot only rely on concatenation.
The PR includes mediaType into the seekbarLabel translatable string as an argument.

How Has This Been Tested?

$ node --version
v24.21.0
$ npm --version
11.19.0
$ npm ci
$ npm run lint
$ npm run build
$ npm run test

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code has proper inline documentation. No need

@DuaelFr
DuaelFr changed the base branch from main to develop October 2, 2026 14:57
@joedolson

joedolson commented Oct 4, 2026

Copy link
Copy Markdown
Member

Thanks! I've been gradually working on removing all the concatenated translations from Able Player, so thanks for the PR!

@joedolson
joedolson merged commit 2b3ba3c into ableplayer:develop Oct 4, 2026
5 checks passed
joedolson added a commit that referenced this pull request Oct 4, 2026
@joedolson
Update changelog
49c9753 
See #792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DuaelFr @joedolson