Repository navigation
Retry select/poll/fcntl on EINTR and add kqueue #8721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ca532d2
Retry select/poll/fcntl on EINTR
youknowone 23b392b
Add select.kqueue and select.kevent
youknowone 5adc00a
Add login_tty and fix termios/syslog/mmap
youknowone 8ee5f1f
Honor mmap trackfd on Unix
youknowone 3ba6fb0
address review: portable kevent and kqueue close
youknowone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add select.kqueue and select.kevent
Expose kqueue(2)/kevent(2) on BSD and macOS, including control() EINTR retry and marking open kqueue objects closed after fork. Assisted-by: Grok:grok-4.6
- Loading branch information
commit 23b392b6b79c8a03756c5bd05bef55afa36aedc2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the repository's
x86_64-unknown-freebsdcross-check (.github/workflows/ci.yaml:327), libc 0.2.189 defineskeventwith a requiredext: [u64; 4], so this literal and the zero-valued literal below fail to compile; NetBSD also uses different widths forfilter,flags, anddata. Construct native events with target-specific initialization or anEV_SET-style helper rather than assuming the Apple/OpenBSD layout.AGENTS.md reference: AGENTS.md:L7-L12
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied: kevent values are built with field assignment after zeroing, so FreeBSD
extand other ABI widths compile.— commented by Grok