Skip to content

Align more error messages with CPython 3.14.5 #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 17 commits into from
May 19, 2026
Merged

Align more error messages with CPython 3.14.5 #7928

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4ec7e61
Cleanup
ShaharNaveh May 19, 2026
b5b2c92
Merge remote-tracking branch 'upstream/main' into ruff-error-msg
ShaharNaveh May 19, 2026
fc0c75b
fixes after merge
ShaharNaveh May 19, 2026
95fb51f
Fixed repeated keyword error message
ShaharNaveh May 19, 2026
e3ab7bc
fix `not` error message
ShaharNaveh May 19, 2026
97a5659
Trailing comma
ShaharNaveh May 19, 2026
b0f24c4
fix more
ShaharNaveh May 19, 2026
eb83c13
Fix more
ShaharNaveh May 19, 2026
a14e54b
More
ShaharNaveh May 19, 2026
3ea23c9
Merge remote-tracking branch 'upstream/main' into ruff-error-msg
ShaharNaveh May 19, 2026
bfec825
clippy
ShaharNaveh May 19, 2026
91147a8
unmark passing tests
ShaharNaveh May 19, 2026
666443d
Fix more
ShaharNaveh May 19, 2026
42005e7
Fix more
ShaharNaveh May 19, 2026
0327d32
cfg gate
ShaharNaveh May 19, 2026
73cb383
Unmark more passing tests
ShaharNaveh May 19, 2026
6a94654
Fix logic error
ShaharNaveh May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unmark passing tests
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed May 19, 2026
commit 91147a87426aa9fc3f462303127f78f4e072f4b0
2 changes: 1 addition & 1 deletion Lib/test/test_metaclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@

Check for duplicate keywords.

>>> class C(metaclass=type, metaclass=type): pass # TODO: RUSTPYTHON # doctest: +EXPECTED_FAILURE
>>> class C(metaclass=type, metaclass=type): pass
...
Traceback (most recent call last):
[...]
Expand Down
3 changes: 0 additions & 3 deletions Lib/test/test_positional_only_arg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def assertRaisesSyntaxError(self, codestr, regex="invalid syntax"):
with self.assertRaisesRegex(SyntaxError, regex):
compile(codestr + "\n", "<test>", "single")

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_invalid_syntax_errors(self):
check_syntax_error(self, "def f(a, b = 5, /, c): pass", "parameter without a default follows parameter with a default")
check_syntax_error(self, "def f(a = 5, b, /, c): pass", "parameter without a default follows parameter with a default")
Expand All @@ -46,7 +45,6 @@ def test_invalid_syntax_errors(self):
check_syntax_error(self, "def f(a, /, c, /, d, *, e): pass")
check_syntax_error(self, "def f(a, *, c, /, d, e): pass")

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_invalid_syntax_errors_async(self):
check_syntax_error(self, "async def f(a, b = 5, /, c): pass", "parameter without a default follows parameter with a default")
check_syntax_error(self, "async def f(a = 5, b, /, c): pass", "parameter without a default follows parameter with a default")
Expand Down Expand Up @@ -235,7 +233,6 @@ def test_lambdas(self):
x = lambda a, b, /, : a + b
self.assertEqual(x(1, 2), 3)

@unittest.expectedFailure # TODO: RUSTPYTHON; wrong error message
def test_invalid_syntax_lambda(self):
check_syntax_error(self, "lambda a, b = 5, /, c: None", "parameter without a default follows parameter with a default")
check_syntax_error(self, "lambda a = 5, b, /, c: None", "parameter without a default follows parameter with a default")
Expand Down
Loading