Skip to content

FOUR-20913: invalidate Screen Cache on Translation changes #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caleeli merged 13 commits into from
Dec 6, 2024
Merged

FOUR-20913: invalidate Screen Cache on Translation changes #7803

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
33c010d
FOUR-20913: invalidate Screen Cache on Translation changes
rodriquelca Dec 5, 2024
207370a
FOUR-20913: Invalidate Screen Cache on Translation changes
rodriquelca Dec 6, 2024
20fa736
clear debug
rodriquelca Dec 6, 2024
8ba8562
fi bad event service provider definition
rodriquelca Dec 6, 2024
5d76ff0
fix test cache factory
rodriquelca Dec 6, 2024
127846d
FOUR-20913: invalidate Screen Cache on Translation changes
rodriquelca Dec 5, 2024
d0fa80b
FOUR-20913: Invalidate Screen Cache on Translation changes
rodriquelca Dec 6, 2024
cf9db1b
clear debug
rodriquelca Dec 6, 2024
1515237
fi bad event service provider definition
rodriquelca Dec 6, 2024
b78499d
fix test cache factory
rodriquelca Dec 6, 2024
5e9f39c
update ScreenCacheManagerTest for failing tests
rodriquelca Dec 6, 2024
039ea48
fix merge conflicts
rodriquelca Dec 6, 2024
aa36aab
complete getOrCache method
rodriquelca Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test cache factory
  • Loading branch information
@rodriquelca
rodriquelca committed Dec 6, 2024
commit 5d76ff0939c0648a7310f6bd1f90119e7cdecd59
18 changes: 10 additions & 8 deletions tests/unit/ProcessMaker/Cache/Screens/ScreenCacheFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use ProcessMaker\Cache\Monitoring\RedisMetricsManager;
use ProcessMaker\Cache\Screens\LegacyScreenCacheAdapter;
use ProcessMaker\Cache\Screens\ScreenCacheFactory;
use ProcessMaker\Cache\Screens\ScreenCacheInterface;
use ProcessMaker\Cache\Screens\ScreenCacheManager;
use ProcessMaker\Managers\ScreenCompiledManager;
use Tests\TestCase;
Expand Down Expand Up @@ -184,16 +185,17 @@ public function testGetScreenCacheReturnsSameInstanceAsCreate()
*/
public function testFactoryRespectsTestInstance()
{
// Create and set a test instance
$testInstance = $this->createMock(ScreenCacheInterface::class);
ScreenCacheFactory::setTestInstance($testInstance);
// Create a mock for ScreenCacheInterface
$mockInterface = $this->createMock(ScreenCacheInterface::class);

// Both create and getScreenCache should return test instance
$this->assertSame($testInstance, ScreenCacheFactory::create());
$this->assertSame($testInstance, ScreenCacheFactory::getScreenCache());
// Set the test instance in the factory
ScreenCacheFactory::setTestInstance($mockInterface);

// Clear test instance
ScreenCacheFactory::setTestInstance(null);
// Retrieve the instance from the factory
$instance = ScreenCacheFactory::create();

// Assert that the instance is the mock we set
$this->assertSame($mockInterface, $instance);
}

/**
Expand Down