Skip to content

FOUR-20913: invalidate Screen Cache on Translation changes #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caleeli merged 13 commits into from
Dec 6, 2024
Merged

FOUR-20913: invalidate Screen Cache on Translation changes #7803

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
33c010d
FOUR-20913: invalidate Screen Cache on Translation changes
rodriquelca Dec 5, 2024
207370a
FOUR-20913: Invalidate Screen Cache on Translation changes
rodriquelca Dec 6, 2024
20fa736
clear debug
rodriquelca Dec 6, 2024
8ba8562
fi bad event service provider definition
rodriquelca Dec 6, 2024
5d76ff0
fix test cache factory
rodriquelca Dec 6, 2024
127846d
FOUR-20913: invalidate Screen Cache on Translation changes
rodriquelca Dec 5, 2024
d0fa80b
FOUR-20913: Invalidate Screen Cache on Translation changes
rodriquelca Dec 6, 2024
cf9db1b
clear debug
rodriquelca Dec 6, 2024
1515237
fi bad event service provider definition
rodriquelca Dec 6, 2024
b78499d
fix test cache factory
rodriquelca Dec 6, 2024
5e9f39c
update ScreenCacheManagerTest for failing tests
rodriquelca Dec 6, 2024
039ea48
fix merge conflicts
rodriquelca Dec 6, 2024
aa36aab
complete getOrCache method
rodriquelca Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clear debug
  • Loading branch information
@rodriquelca
rodriquelca committed Dec 6, 2024
commit 20fa7367c548a31df2d2389ef36d21fe63511bd9
42 changes: 1 addition & 41 deletions ProcessMaker/Listeners/InvalidateScreenCacheOnTranslationChange.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,30 +15,9 @@ class InvalidateScreenCacheOnTranslationChange
public function handle(TranslationChanged $event): void
{
try {
Log::debug('TranslationChanged event received', [
'event' => [
'language' => $event->language,
'changes' => $event->changes,
'screenId' => $event->screenId,
],
]);

if ($event->screenId) {
Log::debug('Attempting to invalidate screen cache', [
'screenId' => $event->screenId,
'language' => $event->language,
]);

$this->invalidateScreen($event->screenId, $event->language);
} else {
Log::debug('No screenId provided, skipping cache invalidation');
}

Log::info('Screen cache invalidated for translation changes', [
'language' => $event->language,
'changes' => array_keys($event->changes),
'screenId' => $event->screenId,
]);
} catch (\Exception $e) {
Log::error('Failed to invalidate screen cache', [
'error' => $e->getMessage(),
Expand All @@ -56,29 +35,10 @@ public function handle(TranslationChanged $event): void
protected function invalidateScreen(string $screenId, string $locale): void
{
try {
Log::debug('Finding screen', ['screenId' => $screenId]);

$screen = Screen::find($screenId);
if ($screen) {
Log::debug('Screen found, getting cache implementation', [
'screen' => [
'id' => $screen->id,
'title' => $screen->title ?? 'N/A',
],
]);

// Get cache implementation from factory
$cache = ScreenCacheFactory::getScreenCache();
Log::debug('Cache implementation obtained', [
'cacheClass' => get_class($cache),
]);

$result = $cache->invalidate($screen->id, $locale);
Log::debug('Cache invalidation completed', [
'result' => $result,
'screenId' => $screen->id,
'locale' => $locale,
]);
$cache->invalidate($screen->id, $locale);
} else {
Log::warning('Screen not found', ['screenId' => $screenId]);
}
Expand Down